Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dialog Consolidation#2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dansiegel merged 25 commits intomasterfromdev/ds/dialogs
Aug 17, 2023
Merged

Dialog Consolidation#2888

dansiegel merged 25 commits intomasterfromdev/ds/dialogs
Aug 17, 2023

Conversation

@dansiegel
Copy link
Member

Description of Change

This aim's to unify the Dialog abstractions to work effectively the same across all platforms. With this we gain the ability to reshare code across WPF, MAUI, Xamarin.Forms, & Uno Platform as the core interfaces reside within the Prism.Core. Note that the Show API and WindowName API in WPF & Uno Platform are now extensions for backwards compatibility . These functions are now driven through KnownDialogParamters.

bdominguez reacted with heart emojiDamianSuess reacted with rocket emoji
@DamianSuess
Copy link
Contributor

Interesting PR on the consolidation. On thePrism.Avalonia's side, I'm currently making some changes to the DialogService for the next 2023-Q2 release. Overall, this looks very beneficial.

@dansiegel Do you foresee any integration issues?

For starters, I was making the ShowDialog'sAction<IDialogResult> callback optional (AvaloniaCommunity/Prism.Avalonia#79).

Also, overloadedShowDialog to optionally supply a parent window for modal dialogs (AvaloniaCommunity/Prism.Avalonia#76). Because Avalonia operates differently than WPF, I have to explicitly set the parent whether it's themain window or another dialog window.

@dansiegel
Copy link
MemberAuthor

@DamianSuess overall I think it should make it easier for you. The Core is meant to have the extensions to provide backwards compatibility. Currently the one thing which is platform specific and may still change is that the extensions for Show are in WPF since this is the only platform which implements such functionality.

@DamianSuess
Copy link
Contributor

DamianSuess commentedJun 23, 2023
edited
Loading

Thanks, Dan, I appreciate the feedback on the topic.
I can rest a bit better this weekend now. Hope you get to as well ;)

@dansiegeldansiegel merged commit9f75a26 intomasterAug 17, 2023
@brianlagunasbrianlagunas deleted the dev/ds/dialogs branchAugust 17, 2023 19:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brianlagunasbrianlagunasbrianlagunas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

Prism 9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dansiegel@DamianSuess@brianlagunas

[8]ページ先頭

©2009-2025 Movatter.jp