- Notifications
You must be signed in to change notification settings - Fork515
Reduce scope of regex in PowerShellExeFinder#5228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
tsmarvin wants to merge1 commit intoPowerShell:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Reduce scope of regex in PowerShellExeFinder#5228
tsmarvin wants to merge1 commit intoPowerShell:mainfromtsmarvin:tsmarvin/make_regex_accurate_to_comments
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the integer checking regex in the PowerShellExeFinder to enforce a stricter validation by matching exactly a single digit rather than one or more digits.
- Change the IntRegex from matching one or more digits (/^\d+$/) to exactly one digit (/^\d$/).
- This adjustment aligns the implementation with the implied expectation from related comments regarding folder naming.
Comments suppressed due to low confidence (1)
src/platform.ts:81
- Consider updating the associated comment to clearly state that the regex now only supports single digit folder names, ensuring that the documentation is consistent with the updated regex behavior.
private static IntRegex = /^\d$/;Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready