Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add an extended Snippet for Advanced Functions fixes #5197#5203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kilasuit wants to merge11 commits intoPowerShell:main
base:main
Choose a base branch
Loading
fromkilasuit:5197

Conversation

kilasuit
Copy link
Contributor

@kilasuitkilasuit commentedMay 24, 2025•
edited
Loading

PR Summary

fixes#5197

Added snippet from ISE with minor edits

  • comment help inside instead of outside the function defintion
  • added clean block and link to docs on this

Adding based on thiscomment on bsky

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting anx between the square brackets.
Please mark anything not applicable to this PRNA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefixWIP: to the beginning of the title and remove the prefix when the PR is ready

@kilasuitkilasuit requested a review froma team as acode ownerMay 24, 2025 23:25
Copy link
Collaborator

@JustinGroteJustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Godo work on the snippet, I'm not quite sure how useful this is though, maybe it should be renamedFunction-Advanced-Doc-Full-Example to indicate it is an example for all the potential options? I personally would never use this, it would take me just as long to clean it up as it would to just write it naked with intellisense :)

@kilasuit
Copy link
ContributorAuthor

@JustinGrote this was a C&P from the one in ISE with very minor edits
But will take comments on board and push an update shortly

@JustinGrote
Copy link
Collaborator

I'll merge it either way, but good to make it as useful as possible yeah?

@JustinGroteJustinGroteenabled auto-merge (squash)June 1, 2025 15:22
Copy link
Collaborator

@JustinGroteJustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, nice work!

JustinGrote

This comment was marked as duplicate.

@JustinGrote
Copy link
Collaborator

@andyleejordan not sure why it's waiting on codeql, I don't see it as an action...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JustinGroteJustinGroteJustinGrote approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an extended Snippet for Advanced Functions
2 participants
@kilasuit@JustinGrote
[8]ページ先頭
©2009-2025 Movatter.jp