Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support notification onpwsh startup when a new update is available#162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joeyaiello merged 11 commits intoPowerShell:masterfromdaxian-dbw:update-notification
Feb 19, 2020

Conversation

daxian-dbw
Copy link
Member

Support notification onpwsh startup when a new update is available.

Today, to find out whether a new version of PowerShell is available, one has to check the release page of thePowerShell\PowerShell repository, or depend on communication channels liketwitter orGitHub Notifications. It would be convenient ifpwsh itself can notify the user of a new update on startup.

SteveL-MSFTand others added3 commitsMarch 25, 2019 12:41
Co-Authored-By: daxian-dbw <dongbow@microsoft.com>
Co-Authored-By: daxian-dbw <dongbow@microsoft.com>
@adityapatwardhan
Copy link
Member

@daxian-dbw Should we have a different message mentioning a security update is available for GA releases? The urgency of updating a preview v/s a GA with security patch is different.

vexx32 and TylerLeonhardt reacted with thumbs up emoji

@daxian-dbw
Copy link
MemberAuthor

@adityapatwardhan Is there a way to know a release is a security release by querying GitHub/release? Or do we need to have a back end to provide that information?

@TravisEz13
Copy link
Member

@daxian-dbw I'll publish security advisories here:https://github.com/powershell/powershell/security/advisories?state=published There probably is an API to read this

@daxian-dbw
Copy link
MemberAuthor

Talked to@adityapatwardhan offline about his comment.

  • pwsh of preview versions should check for the new preview version as well as the new GA version.
  • pwsh of GA versions should check for the new GA version only

So whether a new stable release is a security patch or not, a stable release ofpwsh will report it asA new PowerShell stable release is available.

rjmholt, vexx32, chuanjiao10, and DarkLite1 reacted with thumbs up emoji

@daxian-dbw
Copy link
MemberAuthor

@chuanjiao10 The auto-upgrade is not a goal of this feature.

@TylerLeonhardt
Copy link
Member

Talked to@adityapatwardhan offline about his comment.

pwsh of preview versions should check for the new preview version as well as the new GA version.
pwsh of GA versions should check for the new GA version only

FWIW, this is the exact behavior of the "update PowerShell" feature that ships in the PowerShell extension for VS Code. So it's nice that we're consistent there.

@TylerLeonhardt
Copy link
Member

Actually@daxian-dbw if you wanna mention that you are leaving the auto-upgrade capability to the VS Code extension since that can make assumptions that powershell itself can't, that might be worthwhile to add to the RFC.

daxian-dbw reacted with thumbs up emoji

@iSazonov
Copy link
Contributor

iSazonov commentedOct 4, 2019
edited
Loading

pwsh of preview versions should check for the new preview version as well as the new GA version.
pwsh of GA versions should check for the new GA version only

Windows 10 has different channels:

  1. Preview - check preview and GA,continue checks preview after install GA - I believe this is that users expect.
  2. GA - checks only GA

Also it seems@bergmeister shared that he install nightly builds every day. Perhaps makes sense follow Windows 10 and also use slow and fast rings.

@joeyaiello
Copy link
Contributor

Per conversation with@rjmholt and@SteveL-MSFT today, we have to think about LTS implications here as well. If I'm on 7.0 LTS and a hypothetical 8.0 stable (non-LTS) comes out, am I being notified about its release? (Ideally, no, but nothing in our implementation addresses this today.)

We should also validate that if 7.0 preview gets "updated" (i.e. side-by-sided) by 7.0 stable, and then a hypothetical 7.1 preview comes out, that 7.0 preview is prompting for update to 7.1 preview.

@joeyaiello
Copy link
Contributor

Coming out of @PowerShell/powershell-committee review, we want to change the environment variable to no longer be a simple opt-out/in but rather a field that can be used to set the "channel". So e.g. a$env:PSNotificationPreference that can be set toDefault,Off, orLTS, where the latter would only provide LTS update notifications in their notifications.

@iSazonov
Copy link
Contributor

iSazonov commentedOct 15, 2019
edited
Loading

Since it is a configuration option I'd expect that it will be in config. Moreover, users will not change this often. Most likely only during installation (installer option).

that can be set to Default, Off, or LTS

  • Default - LTS on GA, Preview on Preview version
  • LTS
  • Preview
  • None

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commentedOct 16, 2019
edited
Loading

On the topic of configuration... this feature might also need to support configuration of Proxies since a percentage of the folks we're trying to notify will be behind a proxy? It might just work already.

We just received an issue invscode-powershell for supporting proxies. This type of configuration is very simple in the PowerShell extension, but I wonder where the best candidate is for this type of configuration in PowerShell... I think in config is probably the best way to do it but then it will need some sort of cmdlet to set these values.

@iSazonov
Copy link
Contributor

@TylerLeonhardt By default HttpClient() uses a system default proxy, also it read environment variables likeHTTP_PROXY.

vexx32, TylerLeonhardt, and daxian-dbw reacted with thumbs up emoji

@joeyaiello
Copy link
Contributor

@daxian-dbw to update this with the latest env variable info, and then @PowerShell/powershell-committee can approve

@joeyaiello
Copy link
Contributor

Only have me,@daxian-dbw, and@SteveL-MSFT in the room, but we're all ready to accept and merge

then a notification about the new release may show up on the same day,
but is guaranteed no later than the next day.

2. If an update check detects a new release, the notification should show up in the same session.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

from an implementation perspective, if this is done as aCmdlet it should be possible for a user to check if a new version is available at any time.

daxian-dbw reacted with thumbs up emoji
@daxian-dbw
Copy link
MemberAuthor

Will update the RFC to mention that the notification message is rendered in inversion.

@daxian-dbw
Copy link
MemberAuthor

Comments: make it explicit that this applies to the PowerShell console host only, and add in the 'alternate proposal' that we may consider to add an API in the engine to check for updates.

@joeyaiellojoeyaiello merged commitc82dbb8 intoPowerShell:masterFeb 19, 2020
@daxian-dbwdaxian-dbw deleted the update-notification branchFebruary 27, 2020 22:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AdilHindistanAdilHindistanAdilHindistan left review comments

@rjmholtrjmholtrjmholt left review comments

@JamesWTruherJamesWTruherJamesWTruher left review comments

@SteveL-MSFTSteveL-MSFTSteveL-MSFT approved these changes

@iSazonoviSazonoviSazonov left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.0-Consider
Development

Successfully merging this pull request may close these issues.

10 participants
@daxian-dbw@adityapatwardhan@TravisEz13@TylerLeonhardt@iSazonov@joeyaiello@AdilHindistan@rjmholt@JamesWTruher@SteveL-MSFT

[8]ページ先頭

©2009-2025 Movatter.jp