- Notifications
You must be signed in to change notification settings - Fork8.1k
Documentation improvement for get-changed-files action#26531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Fix README.md: Change "Handles up to 100 changed files" to "Handles all changed files (no limit)"- Fix README.md: Add actions/checkout step to basic usage example- Fix README.md: Improve limitations section with better filter pattern description- Fix action.yml: Change filter logic to use case-sensitive comparison for consistency with gitCo-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
TravisEz13 commentedNov 25, 2025
@copilot the filter was supposed to be case insensitive, revert that change and add a comment to make that clear |
Reverts the case-sensitivity change per review feedback. The filter isintentionally case-insensitive for cross-platform consistency. Addedcomment to clarify this design decision.Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR improves the documentation for theget-changed-files reusable composite action. The changes clarify pagination behavior, filter pattern support, and add a necessary prerequisite step to the usage example. This documentation-only change makes the action easier to understand and use correctly.
Key changes:
- Clarifies that the action handles all changed files without limits (pagination support was already implemented)
- Adds explicit case-insensitive filter matching comment in the action code
- Includes checkout step in usage example (required for local action references)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/actions/infrastructure/get-changed-files/action.yml | Adds inline comment documenting case-insensitive filter behavior for cross-platform consistency |
.github/actions/infrastructure/get-changed-files/README.md | Updates documentation to clarify no file limit, adds checkout step to usage example, and provides clearer explanation of supported filter patterns |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days. |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request updates the reusable composite GitHub Action for retrieving changed files in a pull request. The main improvements include removing the file count limit, clarifying filter pattern support, and ensuring case-insensitive filter matching for consistency across platforms.
Changed file retrieval and filtering:
.github/actions/infrastructure/get-changed-files/README.md)*.ext) and path prefix matching are supported; complex glob or regex patterns are not. (.github/actions/infrastructure/get-changed-files/README.md).github/actions/infrastructure/get-changed-files/action.yml)Documentation improvements:
.github/actions/infrastructure/get-changed-files/README.md)PR Context
Implements actionable feedback from automated code review on PR#26529. The case-insensitive filter behavior is intentional for cross-platform consistency, and a clarifying comment was added to document this design decision.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our2 minute survey.