Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ensure that socket timeouts are set only during the token validation#26066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daxian-dbw merged 3 commits intomasterfromTravisEz13-patch-4
Sep 22, 2025

Conversation

@TravisEz13
Copy link
Member

@TravisEz13TravisEz13 commentedSep 17, 2025
edited
Loading

PR Summary

This pull request refactors how socket timeouts are managed during token validation inRemoteSessionHyperVSocket.cs. The main goal is to ensure that socket timeouts are set only during the token validation phase and are properly reset afterward, improving reliability and preventing unintended blocking or premature timeouts in subsequent operations.

Socket Timeout Management Improvements:

  • Moved the setting of socket receive and send timeouts from theRemoteSessionHyperVSocketServer constructor to theValidateToken method, ensuring timeouts are applied only during token validation.[1][2]
  • Reset the socket receive and send timeouts to zero (disabling them) immediately after successful token validation, preventing timeouts from affecting later socket operations.

PR Context

This theoretical regression in#26057
This is theoretical because this code is not currently exercised.

PR Checklist

@TravisEz13TravisEz13 changed the titleRemove socket timeout configurationEnsure that socket timeouts are set only during the token validationSep 18, 2025
@TravisEz13TravisEz13 added CL-EngineIndicates that a PR should be marked as an engine change in the Change Log 7.5-regressionThe issue is a regression 7.4-regressionRegression in 7.4 labelsSep 18, 2025
}

// Acknowledge the token is valid with "PASS".
socket.Send("PASS"u8);
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comment on behalf colleague, Can the timeout be triggered accidentally here?

@TravisEz13
Copy link
MemberAuthor

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@daxian-dbwdaxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

TravisEz13 reacted with hooray emoji
@daxian-dbw
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daxian-dbwdaxian-dbw merged commit2376e28 intomasterSep 22, 2025
36 of 39 checks passed
@daxian-dbwdaxian-dbw deleted the TravisEz13-patch-4 branchSeptember 22, 2025 17:56
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-servicebot commentedSep 22, 2025
edited by unfurl-linksbot
Loading

📣 Hey @@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull requestSep 22, 2025
…owerShell#26066)The main goal is to ensure that socket timeouts are set only during the token validation phase and are properly reset afterward, improving reliability and preventing unintended blocking or premature timeouts in subsequent operations.
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull requestSep 22, 2025
…owerShell#26066)The main goal is to ensure that socket timeouts are set only during the token validation phase and are properly reset afterward, improving reliability and preventing unintended blocking or premature timeouts in subsequent operations.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@daxian-dbwdaxian-dbwdaxian-dbw approved these changes

Assignees

No one assigned

Labels

7.4-regressionRegression in 7.47.5-regressionThe issue is a regressionBackport-7.4.x-MigratedBackport-7.5.x-MigratedCL-EngineIndicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TravisEz13@daxian-dbw@adityapatwardhan

[8]ページ先頭

©2009-2025 Movatter.jp