Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Merge Errors from #25401 and Internal 33077#25478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jshigetomi merged 1 commit intorelease/v7.4fromfixMergeErrors
Apr 28, 2025

Conversation

jshigetomi
Copy link
Collaborator

@jshigetomijshigetomi commentedApr 28, 2025
edited
Loading

PR Summary

This pull request includes updates to pipeline templates to fix a condition for publishing NuGet packages and remove an unused variable in a blob storage operation. These changes improve the correctness and maintainability of the release pipeline scripts.

Pipeline Condition Fixes:

  • .pipelines/templates/release-githubNuget.yml: Updated the condition for publishing NuGet packages to correctly check if theskipPublish parameter is set totrue instead offalse. This ensures the condition aligns with the intended behavior.

Code Cleanup:

PR Context

PR Checklist

@jshigetomijshigetomi marked this pull request as ready for reviewApril 28, 2025 22:36
@jshigetomijshigetomi requested a review froma team as acode ownerApril 28, 2025 22:36
@jshigetomijshigetomi added the CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log labelApr 28, 2025
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes merge errors in the pipeline templates by updating a NuGet publish condition and cleaning up an unused variable in a blob storage script.

  • Updated the condition in release-githubNuget.yml to properly check the skipPublish parameter.
  • Removed the unused $prefix variable in release-MakeBlobPublic.yml, however its usage remains in the blob retrieval command.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
.pipelines/templates/release-githubNuget.ymlUpdated the condition for NuGet publishing to align with intended behavior.
.pipelines/templates/release-MakeBlobPublic.ymlRemoved the unused variable but did not remove its subsequent usage.
Comments suppressed due to low confidence (1)

.pipelines/templates/release-MakeBlobPublic.yml:163

  • The removed $prefix variable is still being referenced when retrieving blobs, which will lead to runtime errors. Either reintroduce the variable or remove its usage.
$blobs = Get-AzStorageBlob -Context $sourceContext -Container $sourceContainerName -Prefix $prefix

@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomijshigetomi changed the titleFix Merge ErrorsFix Merge Errors in #25475Apr 28, 2025
@jshigetomijshigetomi changed the titleFix Merge Errors in #25475Fix Merge Errors from #25401 and Internal 33077Apr 28, 2025
@jshigetomijshigetomi merged commit63f42af intorelease/v7.4Apr 28, 2025
41 of 42 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedApr 28, 2025
edited by unfurl-linksbot
Loading

📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@jshigetomijshigetomi deleted the fixMergeErrors branchJune 17, 2025 02:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@TravisEz13TravisEz13TravisEz13 approved these changes

Assignees
No one assigned
Labels
CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jshigetomi@TravisEz13

[8]ページ先頭

©2009-2025 Movatter.jp