- Notifications
You must be signed in to change notification settings - Fork7.7k
Fix Merge Errors from #25401 and Internal 33077#25478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes merge errors in the pipeline templates by updating a NuGet publish condition and cleaning up an unused variable in a blob storage script.
- Updated the condition in release-githubNuget.yml to properly check the skipPublish parameter.
- Removed the unused $prefix variable in release-MakeBlobPublic.yml, however its usage remains in the blob retrieval command.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.pipelines/templates/release-githubNuget.yml | Updated the condition for NuGet publishing to align with intended behavior. |
.pipelines/templates/release-MakeBlobPublic.yml | Removed the unused variable but did not remove its subsequent usage. |
Comments suppressed due to low confidence (1)
.pipelines/templates/release-MakeBlobPublic.yml:163
- The removed $prefix variable is still being referenced when retrieving blobs, which will lead to runtime errors. Either reintroduce the variable or remove its usage.
$blobs = Get-AzStorageBlob -Context $sourceContext -Container $sourceContainerName -Prefix $prefix
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
63f42af
intorelease/v7.4Uh oh!
There was an error while loading.Please reload this page.
microsoft-github-policy-servicebot commentedApr 28, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request includes updates to pipeline templates to fix a condition for publishing NuGet packages and remove an unused variable in a blob storage operation. These changes improve the correctness and maintainability of the release pipeline scripts.
Pipeline Condition Fixes:
.pipelines/templates/release-githubNuget.yml
: Updated the condition for publishing NuGet packages to correctly check if theskipPublish
parameter is set totrue
instead offalse
. This ensures the condition aligns with the intended behavior.Code Cleanup:
.pipelines/templates/release-MakeBlobPublic.yml
: Removed the unused$prefix
variable in the blob storage operation script, improving code clarity and maintainability.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright header