Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments#25357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@pwshBot
Copy link
Collaborator

@pwshBotpwshBot commentedApr 14, 2025•
edited by TravisEz13
Loading

Backport of#25022 to release/v7.5

Triggered by@TravisEz13 on behalf of@daxian-dbw

Original CL Label: CL-Engine

/cc @PowerShell/powershell-maintainers

Impact

Choose either tooling or Customer impact.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Issue with some parameters to calls not getting logged to AMSI.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

manually tested by turning on the console log

Risk

  • High
  • Medium
  • Low

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

@TravisEz13TravisEz13 changed the title[release/v7.5]!!!MERGE_CONFLICT!!! Move .NET method invocation logging to after the needed type conversion is done for method arguments[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method argumentsApr 14, 2025
@TravisEz13TravisEz13 added the CL-EngineIndicates that a PR should be marked as an engine change in the Change Log labelApr 14, 2025
@TravisEz13TravisEz13 marked this pull request as draftApril 14, 2025 22:52
Copy link
Member

@daxian-dbwdaxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good except for 1 issue.

@TravisEz13TravisEz13 marked this pull request as ready for reviewApril 15, 2025 20:38
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelApr 22, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelJun 3, 2025
@TravisEz13TravisEz13enabled auto-merge (squash)June 3, 2025 20:07
@TravisEz13TravisEz13 merged commitbd83cba intoPowerShell:release/v7.5Jun 3, 2025
41 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-servicebot commentedJun 3, 2025•
edited by unfurl-linksbot
Loading

📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@cole67
Copy link

pwshBot:backport/release/v7.5/25022-7be2e9e8f

@luckykargbo
Copy link

yes

@khulekanimbanjwa9-design

pwshBot:backport/release/v7.5/25022-7be2e9e8f

Copy link

@EbaooneEbaoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ebaone

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelSep 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@daxian-dbwdaxian-dbwdaxian-dbw left review comments

@TravisEz13TravisEz13TravisEz13 approved these changes

+1 more reviewer

@EbaooneEbaooneEbaoone requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BackPort-7.5.x-DoneCL-EngineIndicates that a PR should be marked as an engine change in the Change LogWaiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pwshBot@TravisEz13@cole67@luckykargbo@khulekanimbanjwa9-design@daxian-dbw@Ebaoone
[8]ページ先頭
©2009-2025 Movatter.jp