Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove the old fuzzy suggestion and fix the local script file name suggestion#25177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfromdaxian-dbw:fuzzy
Mar 17, 2025

Conversation

@daxian-dbw
Copy link
Member

PR Summary

The fuzzy command name suggestion forCommandNotFound error was moved out from experimental feature, but it (the legacy suggestion) doesn't work properly without theFeedbackProvider feature enabled (see the screenshot below).

image

This PR makes the following changes:

  1. Remove the legacy suggestion for fuzzy command names.
  2. Fix the resource string for the legacy suggestion for local script file name.
  3. Rename the built-in feedback provider fromgeneral toGeneral Feedback.

PR Context

PR Checklist

@daxian-dbwdaxian-dbw added CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log BackPort-7.4.x-Consider BackPort-7.5.x-Consider and removed BackPort-7.4.x-Consider labelsMar 14, 2025
Copy link
Member

@SteveL-MSFTSteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should eventually move the other built-in suggestion regarding running exes from current directory to a FeedbackProvider and remove the legacy suggestion code completely

@daxian-dbw
Copy link
MemberAuthor

@SteveL-MSFT the other built-in suggestion was already moved to the FeedbackProvider code path (GeneralCommandErrorFeedback)

// See if target is actually an executable file in current directory.
varlocalTarget=Path.Combine(".",target);
varcommand=invocation.GetCommand(
localTarget,
CommandTypes.Application|CommandTypes.ExternalScript);
if(commandis notnull)
{
returnnewFeedbackItem(
StringUtil.Format(SuggestionStrings.Suggestion_CommandExistsInCurrentDirectory,target),
newList<string>{localTarget});
}

Currently we still go through the old suggestion when the FeedbackProvider exp feature is disabled. Once FeedbackProvider exp feature is considered ready to move to stable, we will remove the old suggestion completely.

@daxian-dbw
Copy link
MemberAuthor

/azp run PowerShell-CI-linux-packaging PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@daxian-dbwdaxian-dbw merged commit48b25da intoPowerShell:masterMar 17, 2025
37 of 38 checks passed
@daxian-dbwdaxian-dbw deleted the fuzzy branchMarch 17, 2025 17:19
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-servicebot commentedMar 17, 2025
edited by unfurl-linksbot
Loading

📣 Hey@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@daxian-dbw
Copy link
MemberAuthor

/backport to release/v7.5

@github-actions
Copy link
Contributor

github-actionsbot commentedMar 17, 2025
edited by unfurl-linksbot
Loading

Started backporting torelease/v7.5:https://github.com/PowerShell/PowerShell/actions/runs/13905810343

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor

@daxian-dbw an error occurred while backporting to "release/v7.5", please check the run log for details!

GitHub Actions is not permitted to create or approve pull requests.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SteveL-MSFTSteveL-MSFTSteveL-MSFT approved these changes

@StevenBucher98StevenBucher98Awaiting requested review from StevenBucher98

Assignees

No one assigned

Labels

Backport-7.5.x-MigratedCL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxian-dbw@SteveL-MSFT@TravisEz13

[8]ページ先頭

©2009-2025 Movatter.jp