Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove Az module installs and AzureRM uninstalls in pipeline#25118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
TravisEz13 merged 7 commits intomasterfromswitchToCFS
Mar 11, 2025

Conversation

jshigetomi
Copy link
Collaborator

@jshigetomijshigetomi commentedMar 3, 2025
edited
Loading

PR Summary

This pull request includes several changes to various pipeline YAML files and the addition of a new PowerShell script. The changes mainly focus on modifying pipeline sources and removing unnecessary PowerShell module installation tasks.

Pipeline source updates:

  • Updated the source ofCoOrdinatedBuildPipeline from 'PowerShell-Coordinated Packages-Official' to 'PowerShell-Coordinated Binaries-Official' in.pipelines/PowerShell-Packages-Official.yml[1].pipelines/PowerShell-Release-Official-Azure.yml[2] and.pipelines/PowerShell-Release-Official.yml[3].

Removal of unnecessary tasks:

  • Removed the task to update theAz.Storage module in.pipelines/templates/checkAzureContainer.yml.
  • Removed the task to install PowerShell modules in.pipelines/templates/compliance/apiscan.yml.
  • Removed the task to install and uninstall PowerShell modules in.pipelines/templates/compliance/generateNotice.yml.
  • Removed the task to removeAzureRM modules and installAz.Storage in.pipelines/templates/release-MakeBlobPublic.yml[1][2].pipelines/templates/release-create-msix.yml[3].pipelines/templates/release-upload-buildinfo.yml[4].pipelines/templates/release-validate-packagenames.yml[5] and.pipelines/templates/uploadToAzure.yml[6].

Addition of a new PowerShell script:

  • Addedtools/installPSResources.ps1 to handle the installation of specific PowerShell modules from either the PSGallery or a custom feed.

PR Context

PR Checklist

@jshigetomi
Copy link
CollaboratorAuthor

/azp run

@jshigetomijshigetomi marked this pull request as ready for reviewMarch 3, 2025 21:28
@jshigetomijshigetomi requested a review froma team as acode ownerMarch 3, 2025 21:28
@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@TravisEz13TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please verify that binary and package builds run.

Copy link
Member

@andyleejordanandyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Half or more of the instances where we're installing Az.Accounts and Az.Storage from the CFS feed using Install-PSResource are happening in places where there's existing logic to check if the PowerShell AzureRM module is installed, and then uninstalling it, and then installing our packages. What's up with that?

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelsMar 3, 2025
@andyleejordan
Copy link
Member

How's this different from#25123?

@jshigetomi
Copy link
CollaboratorAuthor

jshigetomi commentedMar 5, 2025
edited
Loading

How's this different from#25123?

This one is going into master, the other one is testing these changes on the internal 7.4.9 release to verify it works. The plan is to merge this into master once its verified on the other branch.
Should be the same thing.

andyleejordan reacted with thumbs up emoji

@jshigetomijshigetomi changed the titleAdd tool to download modules from CFS and change download methods in pipeliineRemove Az module installs and AzureRM uninstalls in pipelineMar 11, 2025
@TravisEz13TravisEz13 added the CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log labelMar 11, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13TravisEz13 merged commit4bc918b intomasterMar 11, 2025
35 of 36 checks passed
@TravisEz13TravisEz13 deleted the switchToCFS branchMarch 11, 2025 19:53
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedMar 11, 2025
edited by unfurl-linksbot
Loading

📣 Hey@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

jshigetomi added a commit that referenced this pull requestMar 12, 2025
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull requestApr 11, 2025
jshigetomi added a commit that referenced this pull requestApr 12, 2025
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TravisEz13TravisEz13TravisEz13 approved these changes

@adityapatwardhanadityapatwardhanadityapatwardhan approved these changes

@andyleejordanandyleejordanAwaiting requested review from andyleejordan

Assignees
No one assigned
Labels
BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jshigetomi@andyleejordan@TravisEz13@adityapatwardhan

[8]ページ先頭

©2009-2025 Movatter.jp