- Notifications
You must be signed in to change notification settings - Fork7.7k
Remove Az module installs and AzureRM uninstalls in pipeline#25118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…pipeline to use the tool
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please verify that binary and package builds run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Half or more of the instances where we're installing Az.Accounts and Az.Storage from the CFS feed using Install-PSResource are happening in places where there's existing logic to check if the PowerShell AzureRM module is installed, and then uninstalling it, and then installing our packages. What's up with that?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
How's this different from#25123? |
jshigetomi commentedMar 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This one is going into master, the other one is testing these changes on the internal 7.4.9 release to verify it works. The plan is to merge this into master once its verified on the other branch. |
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
4bc918b
intomasterUh oh!
There was an error while loading.Please reload this page.
microsoft-github-policy-servicebot commentedMar 11, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request includes several changes to various pipeline YAML files and the addition of a new PowerShell script. The changes mainly focus on modifying pipeline sources and removing unnecessary PowerShell module installation tasks.
Pipeline source updates:
CoOrdinatedBuildPipeline
from 'PowerShell-Coordinated Packages-Official' to 'PowerShell-Coordinated Binaries-Official' in.pipelines/PowerShell-Packages-Official.yml
[1].pipelines/PowerShell-Release-Official-Azure.yml
[2] and.pipelines/PowerShell-Release-Official.yml
[3].Removal of unnecessary tasks:
Az.Storage
module in.pipelines/templates/checkAzureContainer.yml
..pipelines/templates/compliance/apiscan.yml
..pipelines/templates/compliance/generateNotice.yml
.AzureRM
modules and installAz.Storage
in.pipelines/templates/release-MakeBlobPublic.yml
[1][2].pipelines/templates/release-create-msix.yml
[3].pipelines/templates/release-upload-buildinfo.yml
[4].pipelines/templates/release-validate-packagenames.yml
[5] and.pipelines/templates/uploadToAzure.yml
[6].Addition of a new PowerShell script:
tools/installPSResources.ps1
to handle the installation of specific PowerShell modules from either the PSGallery or a custom feed.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).