- Notifications
You must be signed in to change notification settings - Fork8.1k
Make Component Manifest Updater use neutral target in addition to RID target#25094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Make Component Manifest Updater use neutral target in addition to RID target#25094
Uh oh!
There was an error while loading.Please reload this page.
Conversation
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
| Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
f467823 intoPowerShell:masterUh oh!
There was an error while loading.Please reload this page.
microsoft-github-policy-servicebot commentedFeb 26, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request includes several changes to the
Get-CGRegistrationsfunction in thetools/findMissingNotices.ps1file to improve the handling of target paths and to skip specific names during TPN (Third Party Notices) generation.Improvements to target path handling:
$neutralTargetfor each runtime pattern to handle neutral targets.Get-ChildItemcommand to include items from the$neutralTargetpath.Enhancements to TPN generation:
$skipNamesarray.$skipNamesarray and included verbose logging for skipped names.[1][2]PR Context
.NET started using multiple targets in .NET 8. This makes this script miss some components.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).