Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make Component Manifest Updater use neutral target in addition to RID target#25094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@TravisEz13
Copy link
Member

@TravisEz13TravisEz13 commentedFeb 26, 2025
edited
Loading

PR Summary

This pull request includes several changes to theGet-CGRegistrations function in thetools/findMissingNotices.ps1 file to improve the handling of target paths and to skip specific names during TPN (Third Party Notices) generation.

Improvements to target path handling:

  • Added a new variable$neutralTarget for each runtime pattern to handle neutral targets.
  • Updated theGet-ChildItem command to include items from the$neutralTarget path.

Enhancements to TPN generation:

  • Introduced a list of names to skip during TPN generation, stored in the$skipNames array.
  • Added logic to skip processing for names in the$skipNames array and included verbose logging for skipped names.[1][2]

PR Context

.NET started using multiple targets in .NET 8. This makes this script miss some components.

PR Checklist

@TravisEz13
Copy link
MemberAuthor

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@SeeminglyScienceSeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@TravisEz13TravisEz13enabled auto-merge (squash)February 26, 2025 17:40
@TravisEz13TravisEz13 merged commitf467823 intoPowerShell:masterFeb 26, 2025
36 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-servicebot commentedFeb 26, 2025
edited by unfurl-linksbot
Loading

📣 Hey@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@TravisEz13TravisEz13 deleted the updateComponentManifestScript branchFebruary 26, 2025 20:12
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull requestFeb 26, 2025
@adityapatwardhanadityapatwardhan added the CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log labelMar 25, 2025
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull requestApr 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SeeminglyScienceSeeminglyScienceSeeminglyScience approved these changes

Assignees

No one assigned

Labels

BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TravisEz13@SeeminglyScience@adityapatwardhan@jshigetomi

[8]ページ先頭

©2009-2025 Movatter.jp