Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Set standard handles explicitly when starting a process with-NoNewWindow#25061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daxian-dbw merged 4 commits intoPowerShell:masterfromdaxian-dbw:process
Mar 4, 2025

Conversation

daxian-dbw
Copy link
Member

PR Summary

Fix#24986

This is a follow-up fix to the changes introduced by#20853.

  • If we are starting a process with a new window, we should leave the standard handles unset when they are not redirected and let Windows figure out the default to use creating the process. Otherwise, the standard input of the new window will be tied with the old window for some reason and causes the new window to be unusable.
  • If we are starting a process re-using the current window (with-NoNewWindow), then we need to explicitly set all the standard handles, especially when any of them is redirected. Otherwise, the un-redirected handles will become invalid.

PR Checklist

@daxian-dbwdaxian-dbw added CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log BackPort-7.5.x-Consider labelsFeb 20, 2025
Copy link
Collaborator

@SeeminglyScienceSeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

daxian-dbw reacted with thumbs up emoji
@daxian-dbw
Copy link
MemberAuthor

/azp run PowerShell-CI-linux-packaging PowerShell-Windows-Packaging-CI

@azure-pipelinesAzure Pipelines
Copy link

No pipelines are associated with this pull request.

@daxian-dbwdaxian-dbw merged commit6e428a8 intoPowerShell:masterMar 4, 2025
32 checks passed
@daxian-dbwdaxian-dbw deleted the process branchMarch 4, 2025 00:17
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedMar 4, 2025
edited by unfurl-linksbot
Loading

📣 Hey@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ltrzesniewskiltrzesniewskiltrzesniewski left review comments

@jborean93jborean93jborean93 left review comments

@iSazonoviSazonoviSazonov left review comments

@SeeminglyScienceSeeminglyScienceSeeminglyScience approved these changes

@SteveL-MSFTSteveL-MSFTAwaiting requested review from SteveL-MSFT

Assignees
No one assigned
Labels
Backport-7.5.x-MigratedCL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start-Process in 7.5.0: invalid handles, no output emitted on Windows
6 participants
@daxian-dbw@ltrzesniewski@jborean93@iSazonov@SeeminglyScience@TravisEz13

[8]ページ先頭

©2009-2025 Movatter.jp