This PR ensures thatNew-Item -Path 'Invalid?' -Force correctly throws an error instead of being suppressed. The change specifically checks forIOException with theHResult code related to invalid characters and allows the exception to propagate, aligning behavior with PowerShell 5.1.

PR Context

ThePowerShell Working Group discussed this issue and agreed that, in the case of invalid characters, the cmdlet should return an error just like in PowerShell 5.1, even when-Force is used. The primary use case of-Force is to ensure success whether the target directory exists, but suppressing invalid character errors introduces inconsistencies. This PR implements a targeted fix by checking for the specificHResult associated with invalid characters, ensuring that such exceptions are not suppressed while maintaining existing behavior for other cases.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all.h,.cpp,.cs,.ps1 and.psm1 files have the correct copyright header
This PR is ready to merge and is notWork in Progress.
- If the PR is work in progress, please add the prefixWIP: or[ WIP ] to the beginning of the title (theWIP bot will keep its status check atPending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- [] None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - [ ] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
  - Impact onPowerShell Editor Services which is used in thePowerShell extension for VSCode
    (which runs in a different PS Host).
    - Issue filed:
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    - Issue filed:
  - Impact onPSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    - Issue filed:
  - Impact onEditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
    - Issue filed:

Do not suppress IOException if it has the specific HResult for invali…

411a576

…d characters

iSazonov reviewed

Feb 4, 2025

View reviewed changes

src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated

		@@ -62,6 +62,9 @@ public sealed partial class FileSystemProvider : NavigationCmdletProvider,

		private const int COPY_FILE_ACTIVITY_ID = 0;
		private const int REMOVE_FILE_ACTIVITY_ID = 0;

		// Windows error code for invalid characters
		private const int ERROR_INVALID_NAME = unchecked((int)0x8007007B);

Copy link

Collaborator

iSazonovFeb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about Linux and MacOS?

Copy link

ContributorAuthor

kborowinskiFeb 4, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately, I have limited knowledge about Linux or macOS. From what I have read, the only invalid character for directory name on Linux is/ (forward slash). I did try to force an exception on Ubuntu withNew-Item -Path 'Invalid/Folder/Name' -Type Directory, and it does not error but instead creates a folder structure. What I can do is to introduce check to not suppressIOException when on Windows.

Perhaps someone with genuine Linux/macOS expertise can advance this commit. If this is not feasible, and the proposed solution is not acceptable, we should consider closing this PR.

Copy link

Collaborator

iSazonovFeb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mklement0 What do you think about non-Windows OS-s? Do you agree that the fix should be only for Windows?

Copy link

Collaborator

iSazonovFeb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since we don't useRuntimeInformation.IsOSPlatform() in the file, we prefer to wrap code with#if UNIX. So I suggest to move the const to code where it is used and use the directive.

iSazonov reviewed

Feb 4, 2025

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1


		Describe "New-Item -Force should throw an error for invalid characters in directory path" -Tags "CI" {
		BeforeAll {
		$invalidPath = Join-Path -Path $TestDrive -ChildPath 'Invalid?'

Copy link

Collaborator

iSazonovFeb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The test should work on Linux and MacOS too.

Copy link

ContributorAuthor

kborowinskiFeb 4, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As mentioned before, I was not able to force invalid directory name error on Ubuntu, therefore I just propose to skip that test when running on Linux or macOS, or if not feasible, close this PR.

Copy link

Contributor

mklement0Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's fine to limit the tests to Windows. The only way to construct an invalid directory path that I'm aware of on Unix-like platforms is to includeNUL (`0) characters, but there's a dedicated check for that already in place (Null character in path.)