- Notifications
You must be signed in to change notification settings - Fork7.7k
Fix GitHub Action filter overmatching#24929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
adityapatwardhan approved these changesFeb 3, 2025
268c7f9
intomaster 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Contributor
microsoft-github-policy-servicebot commentedFeb 3, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull requestFeb 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log MustHave
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request includes changes to streamline and centralize the configuration for path filtering in GitHub Actions workflows. The most important changes involve the creation of a shared filter configuration file and the modification of multiple CI workflow files to use this shared configuration.
Centralization of path filters:
.github/action-filters.yml
: Created a new file to define shared path filters for different components likegithub
,tools
,props
,tests
,mainSource
, andbuildModule
.Updates to CI workflows:
.github/workflows/linux-ci.yml
: Updated to use the shared path filters from.github/action-filters.yml
and added a step to capture outputs..github/workflows/macos-ci.yml
: Updated to use the shared path filters from.github/action-filters.yml
and added a step to capture outputs..github/workflows/windows-ci.yml
: Updated to use the shared path filters from.github/action-filters.yml
and added a step to capture outputs.PR Context
The actions were overmatching after moving to
dorny/paths-filters
because it does a logical or of all filters including thenot
(!
) statements.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).