Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Converts_charactersRequiringQuotes in Completion Completers toSearchValues<char> for more efficient char searching#24879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ArmaanMcleod
Copy link
Contributor

@ArmaanMcleodArmaanMcleod commentedJan 27, 2025
edited
Loading

PR Summary

Converteds_charactersRequiringQuotes toSearchValues<char> to do optimized char searching.

I have not included benchmarks but given this was introduced in .NET 8 and provides more readability thanIndexOfAny anyways. It will also have performance benefits if we add more characters in the future and saves from having to optimize this later.

Follow up from discussion with@iSazonov in#24839

PR Context

PR Checklist

@ArmaanMcleodArmaanMcleod changed the titleConverts_charactersRequiringQuotes in Completion Completers to SearchValues<char> for more efficient char searchingConverts_charactersRequiringQuotes in Completion Completers toSearchValues<char> for more efficient char searchingJan 27, 2025
@iSazonov

This comment was marked as outdated.

@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelJan 27, 2025
@azure-pipelinesAzure Pipelines

This comment was marked as outdated.

@iSazonov

This comment was marked as outdated.

@azure-pipelinesAzure Pipelines

This comment was marked as outdated.

@iSazonov
Copy link
Collaborator

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@iSazonoviSazonov self-assigned thisJan 28, 2025
@iSazonoviSazonov merged commitc1abc73 intoPowerShell:masterJan 28, 2025
34 of 36 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedJan 28, 2025
edited by unfurl-linksbot
Loading

📣 Hey@ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iSazonoviSazonoviSazonov approved these changes

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ArmaanMcleod@iSazonov

[8]ページ先頭

©2009-2025 Movatter.jp