- Notifications
You must be signed in to change notification settings - Fork7.7k
Converts_charactersRequiringQuotes
in Completion Completers toSearchValues<char>
for more efficient char searching#24879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
iSazonov merged 4 commits intoPowerShell:masterfromArmaanMcleod:char-array-to-search-valuesJan 28, 2025
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ficient char searching
s_charactersRequiringQuotes
in Completion Completers to SearchValues<char> for more efficient char searchings_charactersRequiringQuotes
in Completion Completers toSearchValues<char>
for more efficient char searching This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
21 tasks
iSazonov approved these changesJan 27, 2025
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
c1abc73
intoPowerShell:master 34 of 36 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Contributor
microsoft-github-policy-servicebot commentedJan 28, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
21 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Converted
s_charactersRequiringQuotes
toSearchValues<char>
to do optimized char searching.I have not included benchmarks but given this was introduced in .NET 8 and provides more readability than
IndexOfAny
anyways. It will also have performance benefits if we add more characters in the future and saves from having to optimize this later.Follow up from discussion with@iSazonov in#24839
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).