Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow DSC parsing through OS architecture translation layers#24852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daxian-dbw merged 5 commits intoPowerShell:masterfrombdeb1337:master
Feb 24, 2025

Conversation

bdeb1337
Copy link
Contributor

PR Summary

This PR replaces the check that restricts parsing DSC configurations when the host OS is of the type ARM.
Instead of checking the host OS, I want to introduce the possibility of checking on process type instead. This way we can allow this for host OS'es that have translation layers to run the x86_64 compiled version of pwsh.

This addresses my issue in#24848 and follows the note/tip of SteveL-MSFT#18781 (comment).

PR Context

I develop DSC(v1) configurations on an ARM mac for use in a windows server environment, and I am currently prohibited of being assisted by the pwsh tooling and interpreter, because the configuration parameter is not "allowed" on ARM hosts.

PR Checklist

bergepro reacted with hooray emoji
@daxian-dbw
Copy link
Member

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Copy link
Member

@daxian-dbwdaxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I made some minor updates to the changes, including a bit cleanup.

bdeb1337 reacted with heart emoji
// Configuration is not supportedonARM64
if (PsUtils.IsRunningOnProcessorArchitectureARM())
// Configuration is not supportedfor ARM orARM64 process architecture.
if (PsUtils.IsRunningOnProcessArchitectureARM())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@SteveL-MSFT You only mentioned ARM64 not supported in#18781 (comment), not ARM, so should we only check for ARM64 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Theconfiguration keyword is only useful on Windows and Windows only supports Arm64 (no Arm32). However, for the code, it's ok to check for ARM as long as it's a superset of 32 and 64. There should be no functional difference as we don't produce Windows Arm32 packages anymore.

daxian-dbw reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So, we are good with the current check.

@bdeb1337
Copy link
ContributorAuthor

@microsoft-github-policy-service agree

WardDeb reacted with rocket emoji

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelJan 31, 2025
@daxian-dbwdaxian-dbw added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelJan 31, 2025
@daxian-dbwdaxian-dbw merged commitc3fbd2c intoPowerShell:masterFeb 24, 2025
39 of 41 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedFeb 24, 2025
edited by unfurl-linksbot
Loading

📣 Hey@bdeb1337, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@daxian-dbwdaxian-dbwdaxian-dbw approved these changes

@adityapatwardhanadityapatwardhanAwaiting requested review from adityapatwardhan

@SteveL-MSFTSteveL-MSFTAwaiting requested review from SteveL-MSFT

Assignees

@daxian-dbwdaxian-dbw

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@bdeb1337@daxian-dbw@SteveL-MSFT

[8]ページ先頭

©2009-2025 Movatter.jp