- Notifications
You must be signed in to change notification settings - Fork7.7k
PMC parse state correctly from update command's response#24850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
TravisEz13 approved these changesJan 23, 2025
/azp run PowerShell-CI-macos, PowerShell-CI-Linux, PowerShell-CI-Windows, PSResourceGet ACR, PowerShell-Windows-Packaging-CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
251bf0d
intoPowerShell:master 12 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Contributor
microsoft-github-policy-servicebot commentedJan 23, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@anamnavi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
TravisEz13 pushed a commit that referenced this pull requestJan 23, 2025
* Parse Json before accessing state property for PMC* fix typo
TravisEz13 added a commit that referenced this pull requestJan 23, 2025
anamnavi added a commit to anamnavi/PowerShell that referenced this pull requestJan 23, 2025
…24850)* Parse Json before accessing state property for PMC* fix typo
anamnavi added a commit to anamnavi/PowerShell that referenced this pull requestJan 23, 2025
…24850)* Parse Json before accessing state property for PMC* fix typo
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Pipe response from PMC command to ConvertFrom-Json before accessing 'state' property and add logging.
This pull request includes changes to the
Publish-PackageToPMC
function in the.pipelines/EV2Specs/ServiceGroupRoot/Shell/Run/Run.ps1
file. The updates improve error handling and logging during the package publishing process.Improvements to error handling and logging:
ConvertFrom-Json
and added a verbose log for the state. This helps in better debugging and understanding the state of the response.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).