Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PMC parse state correctly from update command's response#24850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfromanamnavi:pmc-state-bugfix
Jan 23, 2025

Conversation

anamnavi
Copy link
Member

@anamnavianamnavi commentedJan 23, 2025
edited by TravisEz13
Loading

PR Summary

Pipe response from PMC command to ConvertFrom-Json before accessing 'state' property and add logging.

This pull request includes changes to thePublish-PackageToPMC function in the.pipelines/EV2Specs/ServiceGroupRoot/Shell/Run/Run.ps1 file. The updates improve error handling and logging during the package publishing process.

Improvements to error handling and logging:

  • Changed the way the state of the update response is retrieved by usingConvertFrom-Json and added a verbose log for the state. This helps in better debugging and understanding the state of the response.
  • Added a verbose log for the publish response state and improved error messages for better clarity. This ensures that any issues during the publish process are clearly logged and easier to diagnose.

PR Context

PR Checklist

@anamnavianamnavi changed the titlePmc state bugfixPMC parse state correctly from update command's responseJan 23, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-macos, PowerShell-CI-Linux, PowerShell-CI-Windows, PSResourceGet ACR, PowerShell-Windows-Packaging-CI

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13TravisEz13 added BackPort-7.4.x-Consider BackPort-7.5.x-Consider CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log labelsJan 23, 2025
@TravisEz13TravisEz13 merged commit251bf0d intoPowerShell:masterJan 23, 2025
12 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedJan 23, 2025
edited by unfurl-linksbot
Loading

📣 Hey@anamnavi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

TravisEz13 pushed a commit that referenced this pull requestJan 23, 2025
* Parse Json before accessing state property for PMC* fix typo
TravisEz13 added a commit that referenced this pull requestJan 23, 2025
…4851)* Parse Json before accessing state property for PMC* fix typoCo-authored-by: Anam Navied <anam.naviyou@gmail.com>
anamnavi added a commit to anamnavi/PowerShell that referenced this pull requestJan 23, 2025
…24850)* Parse Json before accessing state property for PMC* fix typo
anamnavi added a commit to anamnavi/PowerShell that referenced this pull requestJan 23, 2025
…24850)* Parse Json before accessing state property for PMC* fix typo
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TravisEz13TravisEz13TravisEz13 approved these changes

Assignees
No one assigned
Labels
BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@anamnavi@TravisEz13

[8]ページ先頭

©2009-2025 Movatter.jp