Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a parameter that skips verify packages step#24763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jshigetomi merged 2 commits intomasterfromaddsskipverify
Jan 10, 2025

Conversation

jshigetomi
Copy link
Collaborator

@jshigetomijshigetomi commentedJan 10, 2025
edited
Loading

PR Summary

This pull request introduces a new parameter,SkipVerifyPackages, to the pipeline configuration files to allow skipping the verification of package licenses. The changes are primarily focused on the addition of this parameter and the conditional logic to handle it.

Pipeline Configuration Enhancements:

  • AddedSkipVerifyPackages parameter to.pipelines/apiscan-gen-notice.yml to control the skipping of package verification.
  • Updated theextends section in.pipelines/apiscan-gen-notice.yml to pass theSkipVerifyPackages parameter to the compliance template.
  • Introduced theSkipVerifyPackages parameter in.pipelines/templates/compliance/generateNotice.yml to be used within the compliance jobs.
  • Added a condition to skip the package verification step in thegenerateNotice job based on theSkipVerifyPackages parameter.
  • Removed unnecessary blank lines in thegenerateNotice job script.

PR Context

PR Checklist

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PowerShell-CI-macos

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PowerShell-CI-linux

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PowerShell-CI-windows

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

1 similar comment
@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PowerShell-CI-static-analysis

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PowerShell-Windows-Packinging-CI

@azure-pipelinesAzure Pipelines
Copy link

No pipelines are associated with this pull request.

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PSResourceGet ACR

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
CollaboratorAuthor

/azp run PowerShell-Windows-Packaging-CI

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomijshigetomienabled auto-merge (squash)January 10, 2025 20:05
@jshigetomijshigetomi merged commit311674b intomasterJan 10, 2025
14 checks passed
@TravisEz13TravisEz13 deleted the addsskipverify branchJanuary 10, 2025 20:06
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedJan 10, 2025
edited by unfurl-linksbot
Loading

📣 Hey@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@TravisEz13TravisEz13 added CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Consider BackPort-7.5.x-Consider BackPort-7.5.x-Approved labelsJan 10, 2025
TravisEz13 pushed a commit that referenced this pull requestJan 15, 2025
* added a parameter that skips verify packages step* fix parameter string to boolean value---------Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull requestJan 16, 2025
* added a parameter that skips verify packages step* fix parameter string to boolean value---------Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 pushed a commit that referenced this pull requestJan 16, 2025
* added a parameter that skips verify packages step* fix parameter string to boolean value---------Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull requestJan 16, 2025
* added a parameter that skips verify packages step* fix parameter string to boolean value---------Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TravisEz13TravisEz13TravisEz13 approved these changes

@daxian-dbwdaxian-dbwAwaiting requested review from daxian-dbw

@adityapatwardhanadityapatwardhanAwaiting requested review from adityapatwardhan

@anmenagaanmenagaAwaiting requested review from anmenaga

Assignees
No one assigned
Labels
BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jshigetomi@TravisEz13

[8]ページ先頭

©2009-2025 Movatter.jp