Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FixRunspacePool,RunspacePoolInternal andRemoteRunspacePoolInternalIDisposable implementation#24720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

xtqqczze
Copy link
Contributor

@xtqqczzextqqczze commentedDec 29, 2024
edited
Loading

  • ImplementIDisposable inSystem.Management.Automation.Runspaces.Internal.RunspacePoolInternal
  • SealSystem.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal type and remove publicDispose method .

@xtqqczzextqqczze reopened thisDec 29, 2024
@xtqqczzextqqczze marked this pull request as ready for reviewDecember 30, 2024 00:53
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelJan 6, 2025
…oolInternal`* Seal internal `System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal` class.* Implement `IDisposable` in base class.
@xtqqczzextqqczzeforce-pushed theseal-System.Management.Automation.Runspaces.Internal branch from1e3bf57 toecc4077CompareJanuary 31, 2025 19:00
@xtqqczzextqqczze changed the titleSealSystem.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternalFixRunspacePoolInternalIDisposable implementationJan 31, 2025
@xtqqczze
Copy link
ContributorAuthor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 24720 in repo PowerShell/PowerShell

@xtqqczze
Copy link
ContributorAuthor

@iSazonov could you run azure pipelines?

@iSazonoviSazonov reopened thisFeb 1, 2025
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelFeb 1, 2025
@iSazonov

This comment was marked as outdated.

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@xtqqczze
Copy link
ContributorAuthor

@iSazonov could you reapprove changes?

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelFeb 9, 2025
@iSazonov
Copy link
Collaborator

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelFeb 10, 2025
@iSazonov
Copy link
Collaborator

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@iSazonoviSazonov added the CL-CodeCleanupIndicates that a PR should be marked as a Code Cleanup change in the Change Log labelFeb 10, 2025
@iSazonoviSazonov self-assigned thisFeb 10, 2025
@iSazonoviSazonov changed the titleFixRunspacePoolInternalIDisposable implementationFixRunspacePool,RunspacePoolInternal andRemoteRunspacePoolInternalIDisposable implementationFeb 10, 2025
@iSazonoviSazonov merged commit57bdd9c intoPowerShell:masterFeb 10, 2025
39 of 41 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedFeb 10, 2025
edited by unfurl-linksbot
Loading

📣 Hey@xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iSazonoviSazonoviSazonov approved these changes

Assignees

@iSazonoviSazonov

Labels
CL-CodeCleanupIndicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@xtqqczze@iSazonov

[8]ページ先頭

©2009-2025 Movatter.jp