PR Summary

UpdatedDnsNameList forX509Certificate2 to useX509SubjectAlternativeNameExtension.EnumerateDnsNames method. This replaces theDNS Name= prefix + OID 2.5.29.17 checking code which is error prone when using different language clients.

Using thepublic X509SubjectAlternativeNameExtension (byte[] rawData, bool critical = false) constructor withcert.RawData did not work and resulted inCryptographicException exceptions. Instead, what was much more robust was just casting the extension toX509SubjectAlternativeNameExtension and then using theEnumerateDnsNames() method.

Also testing previous code with different culture/locale I could not get DNS name prefix to output in a different language, so that case is a bit difficult to reproduce. Although it seems like this is supposed to just work moving to the .NETEnumerateDnsNames() method. I am not even sure switching cultures is good enough to expose this problem and how it can even be validated in the tests.

PR Context

Fixes#24594

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all.h,.cpp,.cs,.ps1 and.psm1 files have the correct copyright header
• This PR is ready to merge and is notWork in Progress.
  • If the PR is work in progress, please add the prefixWIP: or[ WIP ] to the beginning of the title (theWIP bot will keep its status check atPending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    - [ ] Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact onPowerShell Editor Services which is used in thePowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact onPSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact onEditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed: