- Notifications
You must be signed in to change notification settings - Fork7.7k
Deploy Box Update#24632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Deploy Box Update#24632
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
TravisEz13 approved these changesDec 12, 2024
b4b283b intoPowerShell:master 11 of 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Contributor
microsoft-github-policy-servicebot commentedDec 12, 2024 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
jshigetomi added a commit to jshigetomi/PowerShell that referenced this pull requestDec 12, 2024
* reverted one time changes* added ob_outputDirectory* added mscode variable group* forgot to move psm1 to ToolArtifact folder* added pipeline name and passing toolartifact through context* added tools* PSPackagesOfficial* removed tools clone* added uploading CL* verbose statements for release tag and release version* trying to regerence variable with step name* checking REPOROOT* removed get child item* Deploy box update* nuget template context pipeline name correction* changed other instances of releasetag* added -Verbose to Copy-Item* checkout task, instead of git clone* changed to Build.SourcesDirectory* removed path specification* removed path* added tsa and credscan* not copying tools to artifacts* official and production---------Co-authored-by: Justin Chung <chungjustin@microsoft.com>Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
This was referencedDec 12, 2024
Closed
TravisEz13 added a commit that referenced this pull requestJan 14, 2025
* reverted one time changes* added ob_outputDirectory* added mscode variable group* forgot to move psm1 to ToolArtifact folder* added pipeline name and passing toolartifact through context* added tools* PSPackagesOfficial* removed tools clone* added uploading CL* verbose statements for release tag and release version* trying to regerence variable with step name* checking REPOROOT* removed get child item* Deploy box update* nuget template context pipeline name correction* changed other instances of releasetag* added -Verbose to Copy-Item* checkout task, instead of git clone* changed to Build.SourcesDirectory* removed path specification* removed path* added tsa and credscan* not copying tools to artifacts* official and production---------Co-authored-by: Justin Chung <chungjustin@microsoft.com>Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
TravisEz13 added a commit that referenced this pull requestJan 14, 2025
* reverted one time changes* added ob_outputDirectory* added mscode variable group* forgot to move psm1 to ToolArtifact folder* added pipeline name and passing toolartifact through context* added tools* PSPackagesOfficial* removed tools clone* added uploading CL* verbose statements for release tag and release version* trying to regerence variable with step name* checking REPOROOT* removed get child item* Deploy box update* nuget template context pipeline name correction* changed other instances of releasetag* added -Verbose to Copy-Item* checkout task, instead of git clone* changed to Build.SourcesDirectory* removed path specification* removed path* added tsa and credscan* not copying tools to artifacts* official and production---------Co-authored-by: Justin Chung <chungjustin@microsoft.com>Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
jshigetomi added a commit that referenced this pull requestJan 15, 2025
* reverted one time changes* added ob_outputDirectory* added mscode variable group* forgot to move psm1 to ToolArtifact folder* added pipeline name and passing toolartifact through context* added tools* PSPackagesOfficial* removed tools clone* added uploading CL* verbose statements for release tag and release version* trying to regerence variable with step name* checking REPOROOT* removed get child item* Deploy box update* nuget template context pipeline name correction* changed other instances of releasetag* added -Verbose to Copy-Item* checkout task, instead of git clone* changed to Build.SourcesDirectory* removed path specification* removed path* added tsa and credscan* not copying tools to artifacts* official and production---------Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull requestJan 16, 2025
* reverted one time changes* added ob_outputDirectory* added mscode variable group* forgot to move psm1 to ToolArtifact folder* added pipeline name and passing toolartifact through context* added tools* PSPackagesOfficial* removed tools clone* added uploading CL* verbose statements for release tag and release version* trying to regerence variable with step name* checking REPOROOT* removed get child item* Deploy box update* nuget template context pipeline name correction* changed other instances of releasetag* added -Verbose to Copy-Item* checkout task, instead of git clone* changed to Build.SourcesDirectory* removed path specification* removed path* added tsa and credscan* not copying tools to artifacts* official and production---------Co-authored-by: Justin Chung <chungjustin@microsoft.com>Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
TravisEz13 added a commit that referenced this pull requestJan 16, 2025
* reverted one time changes* added ob_outputDirectory* added mscode variable group* forgot to move psm1 to ToolArtifact folder* added pipeline name and passing toolartifact through context* added tools* PSPackagesOfficial* removed tools clone* added uploading CL* verbose statements for release tag and release version* trying to regerence variable with step name* checking REPOROOT* removed get child item* Deploy box update* nuget template context pipeline name correction* changed other instances of releasetag* added -Verbose to Copy-Item* checkout task, instead of git clone* changed to Build.SourcesDirectory* removed path specification* removed path* added tsa and credscan* not copying tools to artifacts* official and production---------Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>Co-authored-by: Justin Chung <chungjustin@microsoft.com>
This was referencedJan 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
BackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request includes significant updates to the PowerShell release pipeline configuration. The changes primarily focus on renaming stages, updating dependencies, and improving the handling of release tags and versions.
Pipeline Configuration Updates:
.pipelines/PowerShell-Release-Official.yml: Removed the temporaryDownloadPackagesstage and added thesetReleaseTagAndUploadToolsstage and updated the corresponding dependencies and templates.setReleaseTagAndUploadToolsstage uploads the github release tool to artifacts and sets up the ReleaseTag and VErsoin variables to be used in the github stage and the nuget stage.[1][2][3]Template Modifications:
.pipelines/templates/release-SetReleaseTagandContainerName.yml: Updated the PowerShell commands to set variables as output and added names for the outputs.[1][2].pipelines/templates/release-SetTagAndTools.yml: Added a new template for setting the release tag and uploading tools, including steps for cloning repositories, signing tools, and uploading changelogs.Job Adjustments:
.pipelines/templates/release-githubtasks.yml: Updated job definitions to use the newsetReleaseTagAndUploadToolsstage and removed redundant steps for setting release tags and versions.[1][2][3].pipelines/templates/release-publish-nuget.yml: Adjusted to use output variables from thesetReleaseTagAndUploadToolsstage and updated artifact names.[1][2]Variable Enhancements:
.pipelines/templates/variable/release-shared.yml: Added parameters and variables forRELEASETAGandVERSION.[1][2]PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).