- Notifications
You must be signed in to change notification settings - Fork7.7k
SetLangVersion compiler option to13.0 in Test.Common.props#24621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -17,13 +17,13 @@ public JsonResult Index() | |||
| Hashtable args = new Hashtable(); | |||
| foreach (var key in Request.Query.Keys) | |||
| { | |||
| args.Add(key, string.Join(Constants.HeaderSeparator, Request.Query[key])); | |||
| args.Add(key, string.Join(Constants.HeaderSeparator,(string)Request.Query[key])); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this should be fixed in Runtime repository. Is there an issue for the pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please report to Runtime repo the issue?
I see there are:
dotnet/runtime#101261
dotnet/runtime#101499
dotnet/runtime#101457@xtqqczze I suggest to revert to 11.0 lang for the test project so that we can merge and don't wait comments from dotnet team.
Originally posted by@iSazonov in#24617 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
dotnet/runtime#101499 is labelledneeds-breaking-change-doc-created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Started discussion:dotnet/runtime#110216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please explicitly report (with repro steps) about the issue with cast needed? I guess it is not doc issue, it should be fixed in Runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems like the issue is withMicrosoft.Extensions.Primitives.StringValues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The issue is a breaking change, resolution is by updating code, e.g.dotnet/aspnetcore@7e353a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Opened issue:dotnet/docs#44102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
test/tools/WebListener/Controllers/GetController.cs(20,38): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]test/tools/WebListener/Controllers/GetController.cs(26,41): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The issue is a breaking change, resolution is by updating code, e.g.dotnet/aspnetcore@7e353a3
@iSazonov This is a confirmed breaking change in .NET 9, seedotnet/docs#44102 (comment).
@iSazonov can you please review? |
/azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
LangVersion compiler option to13.0LangVersion compiler option to13.0 in Test.Common.propsf22ad2e intoPowerShell:masterUh oh!
There was an error while loading.Please reload this page.
microsoft-github-policy-servicebot commentedFeb 8, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
Uh oh!
There was an error while loading.Please reload this page.
Close#24622
test/Test.Common.props