- Notifications
You must be signed in to change notification settings - Fork8.1k
Fix Progress Preference variable in adv functions#24591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@iSazonov -- Resubmitted, included changes to test names as requested |
Request for Engine-Performance group. The PR updates code with performance optimizations. Please make conclusion about performance risks in some (maybe edge) scenarios. |
RylandDeGregory commentedMar 18, 2025
When should we expect this to be merged? It’s been an open PR for 4 months now… |
daxian-dbw commentedJun 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@cmkb3 Sorry it took so long to review this PR! The fix looks good, but I pushed a commit for 2 minor changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
b502098 intoPowerShell:masterUh oh!
There was an error while loading.Please reload this page.
Thanks for reviewing and merging this bugfix. Hopefully we can have it backported as well! |
PR Summary
!Resubmission
This fixes an array out of bounds/type error that occurs when using the -ProgressAction common parameter in advanced functions. The reference variable and variable type arrays are missing the ProgressPreference entry which causes various engine errors including index out of bounds and invalid typecast from index collision.
PR Context
Fixes:#21074 'The -ProgressAction parameter doesn't work (PowerShell 7.4.1 only)'
Fixes:#20657 'The new -ProgressAction common parameter breaks calls to advanced scripts and functions. '
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).