- Notifications
You must be signed in to change notification settings - Fork7.7k
Checkin generated manpage#24423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
adityapatwardhan requested changesOct 14, 2024
Uh oh!
There was an error while loading.Please reload this page.
adityapatwardhan approved these changesOct 14, 2024
adityapatwardhan approved these changesOct 14, 2024
ac8ab0d
intoPowerShell:master 37 of 45 checks passed
Uh oh!
There was an error while loading.Please reload this page.
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull requestOct 15, 2024
* checkin generataed manpage* move ronn file into new folder* update build and release to use new asset* add a minimal macos packaging test* add correct dependency for the macos packaging stage* fix packaging error* remove removing files
adityapatwardhan added a commit that referenced this pull requestOct 15, 2024
adityapatwardhan pushed a commit that referenced this pull requestOct 22, 2024
* checkin generataed manpage* move ronn file into new folder* update build and release to use new asset* add a minimal macos packaging test* add correct dependency for the macos packaging stage* fix packaging error* remove removing files
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull requestOct 31, 2024
* checkin generataed manpage* move ronn file into new folder* update build and release to use new asset* add a minimal macos packaging test* add correct dependency for the macos packaging stage* fix packaging error* remove removing files
adityapatwardhan added a commit that referenced this pull requestOct 31, 2024
This was referencedJan 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Backport-7.2.x-DoneBackPort-7.4.x-DoneBackPort-7.5.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This pull request introduces several changes to the macOS packaging process, including updates to the build scripts and dependencies. The most significant changes involve adding a new packaging stage, removing the
ronn
dependency, and updating the man page generation process.macOS Packaging Process:
PackageMac
stage to the.vsts-ci/mac.yml
file, which depends on theBuildMac
stage and includes steps for macOS packaging using PowerShell. (.vsts-ci/mac.yml
)Dependency Management:
ronn
dependency from theStart-PSBootstrap
function inbuild.psm1
and theGet-PackageDependencies
function intools/packaging/packaging.psm1
. (build.psm1
)[1] (tools/packaging/packaging.psm1
)[2]Man Page Generation:
roff
instead ofronn
in theNew-ManGzip
function intools/packaging/packaging.psm1
. (tools/packaging/packaging.psm1
)pwsh
inassets/manpage/pwsh.1
. (assets/manpage/pwsh.1
)PR Context
macOS man page generation is failing. Checking in asset so we can get the release working.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).