Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix found during 7.5-preview.5 release#24368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jshigetomi
Copy link
Collaborator

@jshigetomijshigetomi commentedOct 2, 2024
edited by TravisEz13
Loading

PR Summary

This pull request includes several updates to the pipeline configuration files to enhance the build and release processes. The most important changes include modifications to thetsaoptions.json file, updates to the pipeline YAML files for SDK validation, VPack creation, and the addition of new YAML files for API scan and notice generation.

Pipeline Configuration Updates:

  • .pipelines/PowerShell-Release-Official.yml:

    • AddedPoolNames group to variables.
    • Updated SDK validation parameters to includeimageName andpoolName.
  • .pipelines/PowerShell-vPack-Official.yml:

    • Changed the default value ofcreateVPack parameter totrue.

New Pipeline YAML Files:

  • .pipelines/apiscan-gen-notice.yml:

    • Added a new YAML file for API scan and notice generation with detailed variables, resources, and stages configuration.
  • .pipelines/templates/compliance/apiscan.yml:

    • Introduced a new YAML file for API scan jobs with specific steps to install modules, download artifacts, and build the source.
  • .pipelines/templates/compliance/generateNotice.yml:

    • Created a new YAML file to generate a notice file, including steps for component detection and uploading the notice.

Other Changes:

  • .config/tsaoptions.json:

    • Updated theareaPath to includepwsh.
  • .pipelines/templates/obp-file-signing.yml:

    • Added a task to signpwsh.exe with a Windows certificate and verify its signature.
  • .pipelines/templates/release-MakeBlobPublic.yml:

    • Modified the job to copy release packages to PSInfra storage instead of making the blob public.
    • Updated the script to copy blobs to PSInfra storage.

PR Context

PR Checklist

Fix typo in release-MakeBlobPublic.yml
Add back local NuGet source for test packages
The test was failing because a relative path was provided to parameter -DestinationPath.Should update Compress-PSResource to accept relative paths for -DestinationPath.----#### AI description  (iteration 1)#### PR ClassificationBug fix for a failing test scenario.#### PR SummaryThis pull request fixes the test scenario for the `Compress-PSResource` function.- `Microsoft.PowerShell.PSResourceGet.Tests.ps1`: Updated the path resolution for `$PublishedNupkgs` using `Resolve-Path` and added a missing line break in the test for compressing a module.
Added 7.5.0-preview.5 change log----#### AI description  (iteration 1)#### PR ClassificationChangelog update for the new preview release.#### PR SummaryThis pull request updates the changelog for the v7.5.0-preview.5 release, documenting breaking changes, engine updates, new features, and other improvements.- `ConvertTo-Json`: Treat large Enum values as numbers.- `Import-Module`: Fix processor architecture validation.- `Resolve-Path` and `Convert-Path`: Add `-Force` parameter to support wildcard hidden files.- `PSResourceGet` test: Fix cleanup.- Various build and packaging improvements, including updates to dependencies and test scenarios.
@@ -197,15 +197,15 @@ Describe "PSResourceGet - Module tests" -tags "Feature" {
}

It "Should compress a module into a .nupkg" {
Compress-PSResource -Path $TestModule -DestinationPath $PublishedNupkgs

Compress-PSResource -Path $TestModule -DestinationPath (Resolve-Path -Path $PublishedNupkgs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change looks like it needs to go to master, is there a PR for that?

- pwsh: |
Get-ChildItem Env:
displayName: 'Capture Environment Variables'
- pwsh: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like it needs to go to master too. Is there a PR for that?

@TravisEz13TravisEz13 marked this pull request as ready for reviewOctober 2, 2024 16:42
@TravisEz13TravisEz13 changed the titleRelease/v7.5.0 preview.5Fix found during 7.5-preview.5 releaseOct 2, 2024
@TravisEz13TravisEz13enabled auto-merge (squash)October 2, 2024 16:43
@TravisEz13TravisEz13 self-assigned thisOct 2, 2024
@TravisEz13TravisEz13 added the CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log labelOct 2, 2024
@TravisEz13TravisEz13 merged commit113e15e intoPowerShell:release/v7.5Oct 2, 2024
35 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedOct 2, 2024
edited by unfurl-linksbot
Loading

📣 Hey@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@jshigetomijshigetomi mentioned this pull requestJan 17, 2025
21 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TravisEz13TravisEz13TravisEz13 approved these changes

@daxian-dbwdaxian-dbwAwaiting requested review from daxian-dbw

@adityapatwardhanadityapatwardhanAwaiting requested review from adityapatwardhan

@anmenagaanmenagaAwaiting requested review from anmenaga

Assignees

@TravisEz13TravisEz13

Labels
CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jshigetomi@TravisEz13@adityapatwardhan

[8]ページ先頭

©2009-2025 Movatter.jp