- Notifications
You must be signed in to change notification settings - Fork7.7k
RemoveSuppressFinalize
fromClientRemoteSessionDSHandlerImpl
#21218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
RemoveSuppressFinalize
fromClientRemoteSessionDSHandlerImpl
#21218
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The motivation of this PR is this comment by@PaulHiginPowerShell#11820 (comment)._Contributes toPowerShell#15110._
This PR has Quantification details
Why proper sizing of changes mattersOptimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email) |
This PR has Quantification details
Why proper sizing of changes mattersOptimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email) |
ClientRemoteSessionDSHandlerImpl
ClientRemoteSessionDSHandlerImpl
src/System.Management.Automation/engine/remoting/client/remotingprotocolimplementation.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ClientRemoteSessionDSHandlerImpl
SuppressFinalize
fromClientRemoteSessionDSHandlerImpl
b74e708
intoPowerShell:masterUh oh!
There was an error while loading.Please reload this page.
microsoft-github-policy-servicebot commentedDec 28, 2024 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
Uh oh!
There was an error while loading.Please reload this page.
Follow-up to#24705.
GC.SuppressFinalize
should not be invoked for types without destructors.ClientRemoteSessionDSHandlerImpl
is sealed therefore cannot have a destructor.