Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update Named and Statement block type inference to not consider AssignmentStatements and Increment/decrement operators as part of their output#21137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

MartinGC94
Copy link
Contributor

@MartinGC94MartinGC94 commentedJan 24, 2024•
edited by iSazonov
Loading

PR Summary

Fixes the type inference of statement blocks and named blocks like:

$i = 0$Result = if ($true){    [System.IO.DirectoryInfo] $WindowsDir = Get-Item -LiteralPath C:\Windows    $i++    $WindowsDir.FullName}

It correctly ignores both assignments and increments/decrements when inferring the output (here is only$WindowsDir.FullName) from such blocks.

PR Context

PR Checklist

@pull-request-quantifier-deprecatedPull Request Quantifier (deprecated)

This PR has30 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra SmallSize       : +15 -15Percentile : 12%Total files changed: 2Change summary by file extension:.cs : +7 -3.ps1 : +8 -12

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@MartinGC94MartinGC94 mentioned this pull requestJan 26, 2024
22 tasks
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelJan 31, 2024
@pull-request-quantifier-deprecatedPull Request Quantifier (deprecated)

This PR has30 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra SmallSize       : +15 -15Percentile : 12%Total files changed: 2Change summary by file extension:.cs : +7 -3.ps1 : +8 -12

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonoviSazonov changed the titleUpdate Named and Statement block inference to not consider AssignmentStatements as part of their outputUpdate Named and Statement block inference to not consider AssignmentStatements and Increment/decrement operators as part of their outputDec 28, 2024
$Int16++; $Int32--; ++$Int64; --$Int128
($Uint16++); ($Uint32--); (++$Uint64); (--$Uint128) }.Ast)
$res.Count | Should -Be 4
$res.Name -join ',' | Should -Be ('System.UInt16', 'System.UInt32', 'System.UInt64', 'System.UInt128' -join ',')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Previous tests have one case with string "Hello" and second one with int and we can distinct string and int.
In the tests all is int-s and it is not clear what is line in the test return non-empty result.
I mean we should check (1) first 3 line, (2) then all 4 line.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can't use strings because++ and-- only work on numbers. I am differentiating the expected VS unexpected results by using 2 different number types (ints and uints).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am differentiating

I was still forced to do a manual check - it is not obvious the tests work correctly.
I suggest making the tests more explicit with two steps:

$res= [AstTypeInference]::InferTypeOf( {            [Int16]$Int16=1; [Int32]$Int32=1; [Int64]$Int64=1; [System.Int128]$Int128=1;            [UInt16]$Uint16=1; [UInt32]$Uint32=1; [UInt64]$Uint64=1; [System.UInt128]$Uint128=1$Int16++;$Int32--;++$Int64;--$Int128}.Ast)$res.Count| Should-Be0$res= [AstTypeInference]::InferTypeOf( {            [Int16]$Int16=1; [Int32]$Int32=1; [Int64]$Int64=1; [System.Int128]$Int128=1;            [UInt16]$Uint16=1; [UInt32]$Uint32=1; [UInt64]$Uint64=1; [System.UInt128]$Uint128=1$Int16++;$Int32--;++$Int64;--$Int128            ($Uint16++); ($Uint32--); (++$Uint64); (--$Uint128) }.Ast)$res.Count| Should-Be4$res.Name-join','| Should-Be ('System.UInt16','System.UInt32','System.UInt64','System.UInt128'-join',')

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure, that makes sense. I've done that now.

@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelDec 29, 2024
@iSazonoviSazonov changed the titleUpdate Named and Statement block inference to not consider AssignmentStatements and Increment/decrement operators as part of their outputUpdate Named and Statement block type inference to not consider AssignmentStatements and Increment/decrement operators as part of their outputDec 29, 2024
@iSazonoviSazonov merged commit57dbde6 intoPowerShell:masterDec 29, 2024
38 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedDec 29, 2024•
edited by unfurl-linksbot
Loading

📣 Hey@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelDec 29, 2024
@MartinGC94MartinGC94 deleted the FixAssignmentInference branchFebruary 28, 2025 18:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iSazonoviSazonoviSazonov approved these changes

@daxian-dbwdaxian-dbwAwaiting requested review from daxian-dbwdaxian-dbw is a code owner

Assignees
No one assigned
Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogExtra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@MartinGC94@iSazonov
[8]ページ先頭
©2009-2025 Movatter.jp