Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add-PropertyType argument completer forNew-ItemProperty#21117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ArmaanMcleod
Copy link
Contributor

@ArmaanMcleodArmaanMcleod commentedJan 20, 2024•
edited
Loading

PR Summary

Fixes#21116

This PR adds an argument completer for Option 1 described in linked issue.

Add-PropertyType argument completer forNew-ItemProperty command.

PR Context

Currently you cannot tab complete registry value kinds forNew-ItemProperty -PropertyType. This PR adds aPropertyTypeArgumentCompleter which matcheswordToComplete against the possible enum values ofRegistryValueKind.

PR Checklist

@ArmaanMcleodArmaanMcleod changed the titleAdd-PropertyType argument completer forNew-ItemPropertyOption 1 - Add-PropertyType argument completer forNew-ItemPropertyJan 20, 2024
@ArmaanMcleodArmaanMcleod changed the titleOption 1 - Add-PropertyType argument completer forNew-ItemPropertyWIP: Option 1 - Add-PropertyType argument completer forNew-ItemPropertyJan 21, 2024
@ArmaanMcleodArmaanMcleod marked this pull request as draftJanuary 21, 2024 11:18
@ArmaanMcleodArmaanMcleod marked this pull request as ready for reviewJanuary 21, 2024 13:17
@ArmaanMcleod
Copy link
ContributorAuthor

Thanks@iSazonov, I've changed implementation to check if registry provider is used.

Also@MartinGC94 let me know what you think, took some inspiration from your argument completer 🙂.

@ArmaanMcleodArmaanMcleod changed the titleWIP: Option 1 - Add-PropertyType argument completer forNew-ItemPropertyOption 1 - Add-PropertyType argument completer forNew-ItemPropertyJan 21, 2024
Copy link
Contributor

@MartinGC94MartinGC94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall logic seems fine, but I agree with@iSazonov suggestion about not converting all of the paths to an array. If you change that + my minor suggestions then I would be fine with this.

ArmaanMcleod reacted with thumbs up emoji
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelJan 21, 2024
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelJan 22, 2024
@ArmaanMcleod
Copy link
ContributorAuthor

Thanks@iSazonov and@MartinGC94 for the comprehensive and helpful feedback. I have made changes to address the comments, please have a look and let me know if I've missed anything.

For the multiple paths, I am now just runningResolve-Path on thefakeBoundParameters as is and checking the first path, got rid of the array converting.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelJan 30, 2024
@ArmaanMcleodArmaanMcleod changed the titleOption 1 - Add-PropertyType argument completer forNew-ItemPropertyAdd-PropertyType argument completer forNew-ItemPropertyJul 7, 2024
@iSazonoviSazonovforce-pushed thenew-itemproperty-property-type-completer branch from2af476e toa8d8dc3CompareDecember 25, 2024 11:42
@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelDec 25, 2024
@iSazonoviSazonov self-assigned thisDec 25, 2024
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelDec 25, 2024
@iSazonoviSazonov merged commite127345 intoPowerShell:masterDec 25, 2024
38 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedDec 25, 2024•
edited by unfurl-linksbot
Loading

📣 Hey@ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iSazonoviSazonoviSazonov approved these changes

@MartinGC94MartinGC94MartinGC94 approved these changes

@daxian-dbwdaxian-dbwAwaiting requested review from daxian-dbw

@adityapatwardhanadityapatwardhanAwaiting requested review from adityapatwardhan

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogMedium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New-ItemProperty -PropertyType should have tab completion
3 participants
@ArmaanMcleod@iSazonov@MartinGC94
[8]ページ先頭
©2009-2025 Movatter.jp