Adds catch forInvalidCastException so non-terminating error gets reported instead of terminating error when listing subkeys with 64 bit integer in 32 bit DWORD.

PR Context

Currently if you do this you get a terminating error for the cast and command is halted. With this exception handling we can now get non-terminating error and also suppress error with-ErrorAction SilentlyContinue.Get-ItemProperty will continue to enumerate subkeys even if an invalid one is found.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all.h,.cpp,.cs,.ps1 and.psm1 files have the correct copyright header
This PR is ready to merge and is notWork in Progress.
- If the PR is work in progress, please add the prefixWIP: or[ WIP ] to the beginning of the title (theWIP bot will keep its status check atPending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
  - Impact onPowerShell Editor Services which is used in thePowerShell extension for VSCode
    (which runs in a different PS Host).
    - Issue filed:
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    - Issue filed:
  - Impact onPSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    - Issue filed:
  - Impact onEditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
    - Issue filed:

ArmaanMcleod added2 commits

January 21, 2024 02:02

Add catch for InvalidCastException

a270ae8

Add tests

fb6d394

ArmaanMcleod requested a review fromanmenaga as acode owner

January 20, 2024 15:08

pull-request-quantifier-deprecatedbot added the Extra Small label

Jan 20, 2024

iSazonov approved these changes

Jan 20, 2024

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1 OutdatedShow resolvedHide resolved

Copy link

Collaborator

iSazonov commentedJan 20, 2024

@ArmaanMcleod We need to skip new test code on Windows.

Copy link

ContributorAuthor

ArmaanMcleod commentedJan 20, 2024•
edited
Loading

@iSazonov Do you mean we should skip if not windows and powershell core? Makes sense if this is for new test it should only work for powershell core on windows.

I've added conditions to lock tests to windows only.

ArmaanMcleod added2 commits

January 21, 2024 03:18

Use reg.exe in test

2956793

Add conditions to only run for windows

a3dbaa5

iSazonov reviewed

Jan 20, 2024

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1 OutdatedShow resolvedHide resolved

iSazonov reviewed

Jan 20, 2024

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1 OutdatedShow resolvedHide resolved

Remove It skip since its already set at top of test file

a84de03

iSazonov reviewed

Jan 21, 2024

View reviewed changes

src/System.Management.Automation/namespaces/RegistryProvider.csShow resolvedHide resolved

iSazonov approved these changes

Jan 21, 2024

View reviewed changes

src/System.Management.Automation/namespaces/RegistryProvider.csShow resolvedHide resolved

iSazonov added CL-General

Indicates that a PR should be marked as a general cmdlet change in the Change Log

PowerShell-Docs not neededThe PR was reviewed and doesn't appear to require a PowerShell Docs update labels

Jan 21, 2024

Check more exception details in test

3eb3181

Copy link

pull-request-quantifier-deprecatedbot commentedJan 21, 2024

This PR has36 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra SmallSize       : +34 -2Percentile : 14.4%Total files changed: 2Change summary by file extension:.cs : +9 -2.ps1 : +25 -0

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using thecontext generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
- Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added:+1 -0
One line was deleted:+0 -1
One line was modified:+1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.