Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use script filepath when completing relative paths for using statements#20017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

MartinGC94
Copy link
Contributor

@MartinGC94MartinGC94 commentedJul 24, 2023
edited by TravisEz13
Loading

PR Summary

Improves the tab completion for paths in using statements like:using module .\<Tab> so the relative path is based on the file instead of the current directory.
Also added file completion forusing assembly .\<Tab>

PR Context

Fixes#19180

PR Checklist

@StevenBucher98StevenBucher98 added the PowerShell-Docs neededThe PR was reviewed and a PowerShell Docs update is needed labelJul 31, 2023
@pull-request-quantifier-deprecated

This PR has45 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra SmallSize       : +40 -5Percentile : 18%Total files changed: 3Change summary by file extension:.cs : +18 -5.ps1 : +22 -0

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added Review - NeededThe PR is being reviewed labelsAug 13, 2023
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

2 similar comments
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@iSazonov
Copy link
Collaborator

@MartinGC94 Please resolve merge conflicts.

MartinGC94 reacted with thumbs up emoji

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelDec 28, 2024
@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelDec 30, 2024
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelJan 6, 2025
@iSazonov

This comment was marked as outdated.

@azure-pipelinesAzure Pipelines

This comment was marked as outdated.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelFeb 26, 2025
@iSazonoviSazonovenabled auto-merge (squash)February 26, 2025 13:06
@iSazonoviSazonov merged commitca519c9 intoPowerShell:masterFeb 27, 2025
39 of 41 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedFeb 27, 2025
edited by unfurl-linksbot
Loading

📣 Hey@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@MartinGC94MartinGC94 deleted the RelativeUsingCompletion branchFebruary 28, 2025 10:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JamesWTruherJamesWTruherJamesWTruher left review comments

@iSazonoviSazonoviSazonov approved these changes

@andyleejordanandyleejordanAwaiting requested review from andyleejordan

@SeeminglyScienceSeeminglyScienceAwaiting requested review from SeeminglyScience

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogExtra SmallPowerShell-Docs neededThe PR was reviewed and a PowerShell Docs update is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path completion forusing module should use the current script filepath if provided by the editor
8 participants
@MartinGC94@iSazonov@JamesWTruher@daxian-dbw@TravisEz13@adityapatwardhan@StevenBucher98@SeeminglyScience

[8]ページ先頭

©2009-2025 Movatter.jp