Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add ExcludeModule parameter to Get-Command#18955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

MartinGC94
Copy link
Contributor

@MartinGC94MartinGC94 commentedJan 17, 2023
edited
Loading

PR Summary

Adds the ExcludeModule parameter to Get-Command so you can exclude commands from specified modules like this:Get-Command *disk* -ExcludeModule Storage.

PR Context

The main purpose is to contribute towards:#16747 but like the previous example shows it can also be useful when manually searching for commands.

PR Checklist

dodexahedron reacted with heart emojialanlivio reacted with eyes emoji
@ThomasNieto
Copy link
Contributor

The parameter name should beExcludeModule to match existing cmdlets that useExclude notExcluded.

iSazonov and doctordns reacted with thumbs up emoji

@MartinGC94MartinGC94 changed the titleAdd ExcludedModule parameter to Get-CommandAdd ExcludeModule parameter to Get-CommandJan 17, 2023
@ghostghost added the Review - NeededThe PR is being reviewed labelJan 25, 2023
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@SteveL-MSFTSteveL-MSFT added the WG-Cmdletsgeneral cmdlet issues labelJan 30, 2023
@SteveL-MSFT
Copy link
Member

Queued this up for the WG-Cmdlets to discuss

@ghostghost removed the Review - NeededThe PR is being reviewed labelJan 30, 2023
@SteveL-MSFT
Copy link
Member

The Cmdlet WG reviewed this and agree with adding this parameter to Get-Command. We're not making any statement on the quality of this PR.

@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelFeb 2, 2023
@pull-request-quantifier-deprecated

This PR has29 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra SmallSize       : +28 -1Percentile : 11.6%Total files changed: 3Change summary by file extension:.cs : +25 -1.ps1 : +3 -0

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghostghost added the Review - NeededThe PR is being reviewed labelFeb 11, 2023
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@daxian-dbwdaxian-dbw added the Needs-TriageThe issue is new and needs to be triaged by a work group. labelMay 1, 2023
@StevenBucher98StevenBucher98 added the PowerShell-Docs neededThe PR was reviewed and a PowerShell Docs update is needed labelMay 15, 2023
@doctordns
Copy link
Collaborator

What is the status of this PR?

alanlivio reacted with thumbs up emoji

@alanlivio
Copy link

Hi all. What is the status of this PR?

@alanlivio
Copy link

Hi all again. Just following up. What is the status of this PR?

@alanlivio
Copy link

Sorry to ask again, but what is the status of this PR@iSazonov and@daxian-dbw?

@MartinGC94
Copy link
ContributorAuthor

MartinGC94 commentedFeb 7, 2024
edited by unfurl-linksbot
Loading

@alanlivio Good news, according to the PS team blogpost:https://devblogs.microsoft.com/powershell/powershell-and-openssh-team-investments-for-2024/ one of the goals for 2024 is to focus on getting community PRs merged. Obviously they haven't started doing that yet, but it would be very weird if they didn't start within the next couple of weeks after making a blog post like that.

PowerShell Team
Planned team investments for 2024 for PowerShell, OpenSSH, and related tooling.
alanlivio reacted with hooray emoji

@alanlivio
Copy link

Good news. I hope that they can merge your PR soon.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept and removed Review - NeededThe PR is being reviewed Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelsMay 13, 2024
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelMay 26, 2024
@MartinGC94
Copy link
ContributorAuthor

This was approved but not merged. Are we waiting for an official 7.5 release before merging or what's the idea here?

@SeeminglyScience
Copy link
Collaborator

Gonna close and reopen to get CI going, once it passes I'll get it merged

@iSazonov
Copy link
Collaborator

@SeeminglyScience The PR is too old - I suggest to rebase before merge.

SeeminglyScience reacted with heart emoji

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelDec 12, 2024
@alanlivio
Copy link

I am looking forward to seeing this merged.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Review - NeededThe PR is being reviewed labelDec 20, 2024
@iSazonoviSazonov merged commitc066cd8 intoPowerShell:masterDec 30, 2024
38 checks passed
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelDec 30, 2024
@MartinGC94MartinGC94 deleted the AddExcludedModuleParam branchFebruary 28, 2025 19:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SteveL-MSFTSteveL-MSFTSteveL-MSFT approved these changes

@iSazonoviSazonoviSazonov approved these changes

@daxian-dbwdaxian-dbwAwaiting requested review from daxian-dbw

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogExtra SmallNeeds-TriageThe issue is new and needs to be triaged by a work group.PowerShell-Docs neededThe PR was reviewed and a PowerShell Docs update is neededWG-Cmdletsgeneral cmdlet issuesWG-ReviewedA Working Group has reviewed this and made a recommendation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10 participants
@MartinGC94@ThomasNieto@SteveL-MSFT@doctordns@alanlivio@SeeminglyScience@iSazonov@daxian-dbw@adityapatwardhan@StevenBucher98

[8]ページ先頭

©2009-2025 Movatter.jp