- Notifications
You must be signed in to change notification settings - Fork7.7k
Do not removepenimc_cor3.dll
from build#18438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR has Quantification details
Why proper sizing of changes mattersOptimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
/backport to release/v7.3.0 |
@adityapatwardhan backporting to release/v7.3.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patchApplying: Do not remove`penimc_cor3.dll` from buildApplying: Fix wix fileUsing index info to reconstruct a base tree...Massets/wix/files.wxsFalling back to patching base and 3-way merge...Auto-merging assets/wix/files.wxsCONFLICT (content): Merge conflictin assets/wix/files.wxserror: Failed to mergein the changes.hint: Use'git am --show-current-patch=diff' to see the failed patchPatch failed at 0002 Fix wix fileWhen you have resolved this problem, run"git am --continue".If you prefer to skip this patch, run"git am --skip" instead.To restore the original branch and stop patching, run"git am --abort".Error: The process'/usr/bin/git' failed withexit code 128 Please backport manually! |
ghost commentedNov 9, 2022
🎉 Handy links: |
ghost commentedDec 20, 2022
🎉 Handy links: |
ghost commentedJun 27, 2023
🎉 Handy links: |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Fix#18414
Do not remove penimc_cor3.dll from the build as it blocks WPF scenarios.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).