Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Do not removepenimc_cor3.dll from build#18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfromadityapatwardhan:ReAddPenImc
Nov 2, 2022

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhanadityapatwardhan commentedNov 1, 2022
edited by daxian-dbw
Loading

PR Summary

Fix#18414

Do not remove penimc_cor3.dll from the build as it blocks WPF scenarios.

PR Context

PR Checklist

@pull-request-quantifier-deprecated

This PR has7 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra SmallSize       : +6 -1Percentile : 2.8%Total files changed: 2Change summary by file extension:.wxs : +4 -0.psm1 : +2 -1

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link
Member

@daxian-dbwdaxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@daxian-dbwdaxian-dbw merged commitf9b6d12 intoPowerShell:masterNov 2, 2022
@daxian-dbwdaxian-dbw added the CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log labelNov 2, 2022
@adityapatwardhanadityapatwardhan deleted the ReAddPenImc branchNovember 2, 2022 01:54
@adityapatwardhan
Copy link
MemberAuthor

/backport to release/v7.3.0

@github-actions
Copy link
Contributor

@adityapatwardhan backporting to release/v7.3.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patchApplying: Do not remove`penimc_cor3.dll` from buildApplying: Fix wix fileUsing index info to reconstruct a base tree...Massets/wix/files.wxsFalling back to patching base and 3-way merge...Auto-merging assets/wix/files.wxsCONFLICT (content): Merge conflictin assets/wix/files.wxserror: Failed to mergein the changes.hint: Use'git am --show-current-patch=diff' to see the failed patchPatch failed at 0002 Fix wix fileWhen you have resolved this problem, run"git am --continue".If you prefer to skip this patch, run"git am --skip" instead.To restore the original branch and stop patching, run"git am --abort".Error: The process'/usr/bin/git' failed withexit code 128

Please backport manually!

@ghost
Copy link

🎉v7.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

🎉v7.2.12 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@daxian-dbwdaxian-dbwdaxian-dbw approved these changes

@TravisEz13TravisEz13Awaiting requested review from TravisEz13

@anmenagaanmenagaAwaiting requested review from anmenaga

@PaulHiginPaulHiginAwaiting requested review from PaulHigin

Assignees

@daxian-dbwdaxian-dbw

Labels
Backport-7.2.x-DoneBackport-7.3.x-DoneCL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change LogExtra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scripts generating WPF fail after upgrading to PowerShell 7.3.0-rc.1
3 participants
@adityapatwardhan@daxian-dbw@TravisEz13

[8]ページ先頭

©2009-2025 Movatter.jp