NotificationsYou must be signed in to change notification settings
Fork7.7k
Star48k

Correct incorrect cmdlet name in script#18374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

daxian-dbw merged 1 commit intoPowerShell:masterfromurizen-source:master

Oct 26, 2022

Merged

Correct incorrect cmdlet name in script#18374

daxian-dbw merged 1 commit intoPowerShell:masterfromurizen-source:master

Oct 26, 2022

Conversation

Copy link

Contributor

urizen-source commentedOct 25, 2022•
edited
Loading

Corrects incorrect cmdlet name in script, which has been causing for instance "Restart-Computer -Computername otherserver -Wait -For Powershell" to never complete.
Also fixes "Restart-Computer -ComputerName $_ -Force -Wait -Timeout 1800" where powershell is implicit.

PR Context

Resolves#12232
Alsoresolves#11002 which is also dependant on this powershell script, and it hangs in the same place.
Issue is that the powershell script invoked has an exception because of the incorrect cmdlet-name, and this exception is silently ignored, so it never determines that any powershell is reachable on restarted servers.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all.h,.cpp,.cs,.ps1 and.psm1 files have the correct copyright header
This PR is ready to merge and is notWork in Progress.
- If the PR is work in progress, please add the prefixWIP: or[ WIP ] to the beginning of the title (theWIP bot will keep its status check atPending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
  - Impact onPowerShell Editor Services which is used in thePowerShell extension for VSCode
    (which runs in a different PS Host).
    - Issue filed:
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    - Issue filed:
  - Impact onPSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    - Issue filed:
  - Impact onEditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
    - Issue filed:

Correct incorrect cmdlet name in script

b0e792f

urizen-source requested review fromdaxian-dbw andadityapatwardhan ascode owners

October 25, 2022 12:35

pull-request-quantifier-deprecatedbot added the Extra Small label

Oct 25, 2022

Copy link

pull-request-quantifier-deprecatedbot commentedOct 25, 2022

This PR has2 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra SmallSize       : +1 -1Percentile : 0.8%Total files changed: 1Change summary by file extension:.cs : +1 -1

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using thecontext generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
- Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added:+1 -0
One line was deleted:+0 -1
One line was modified:+1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.