Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Return correct FileName property for Get-Item when listing alternate data streams#18019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iSazonov merged 6 commits intoPowerShell:masterfromkilasuit:18018
Jan 2, 2025

Conversation

kilasuit
Copy link
Collaborator

@kilasuitkilasuit commentedSep 3, 2022
edited
Loading

PR Summary

Fixes#18018

PR Context

PR Checklist

0xfeeddeadbeef reacted with heart emoji
Copy link
Contributor

@dkaszewsdkaszews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If you change "Fixes issue#18018" to "Fixes#18018" in description, it should link properly with "In-PR" tag and autoclose on merge; now it's just a mention.

kilasuit reacted with thumbs up emoji
@ghostghost added the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelSep 7, 2022
@ghostghost removed the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelSep 20, 2022
@ghostghost added the Review - NeededThe PR is being reviewed labelSep 28, 2022
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@TravisEz13
Copy link
Member

@kilasuit Please resolve conflicts.
@iSazonov can you please update your review?

@ghostghost removed the Review - NeededThe PR is being reviewed labelMay 8, 2023
@TravisEz13TravisEz13 added the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelMay 8, 2023
@ghostghost removed the Waiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept labelMay 10, 2023
@kilasuit
Copy link
CollaboratorAuthor

@TravisEz13 not sure why those tests are failing

@pull-request-quantifier-deprecated

This PR has8 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra SmallSize       : +5 -3Percentile : 3.2%Total files changed: 2Change summary by file extension:.cs : +1 -2.ps1 : +4 -1

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov
Copy link
Collaborator

Reopen to restart Windows CIs.

@ghostghost added the Review - NeededThe PR is being reviewed labelMay 18, 2023
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@iSazonoviSazonov merged commit61e9f5d intoPowerShell:masterJan 2, 2025
38 checks passed
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelJan 2, 2025
@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelJan 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SteveL-MSFTSteveL-MSFTSteveL-MSFT left review comments

@iSazonoviSazonoviSazonov approved these changes

@dkaszewsdkaszewsdkaszews approved these changes

@anmenagaanmenagaAwaiting requested review from anmenaga

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogExtra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-Item returns invalid FileName when listing alternate data streams
5 participants
@kilasuit@TravisEz13@iSazonov@SteveL-MSFT@dkaszews

[8]ページ先頭

©2009-2025 Movatter.jp