Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add helper in EnumSingleTypeConverter to get enum names as array#17785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iSazonov merged 4 commits intoPowerShell:masterfromfflaten:cleanup-getenumnames
Jan 2, 2025

Conversation

fflaten
Copy link
Contributor

PR Summary

Adds a helper inEnumSingleTypeConverter to get enum names-array.
Updates switch statement completer to use the new helper instead of string joining + splitting.

PR Context

Related#17750 (comment)

There's another occurrence inCompletionCompleters.cs which is replaced as part of the PR above.

PR Checklist

@fflatenfflaten changed the titleUse helper in EnumSingleTypeConverter to get enum names-arrayAdd helper in EnumSingleTypeConverter to get enum names-arrayJul 27, 2022
@fflaten
Copy link
ContributorAuthor

Feels like random failures. Rerun?

@fflaten
Copy link
ContributorAuthor

fflaten commentedJul 28, 2022
edited
Loading

Just noticed that#17684 plan to replace this code. This PR can be closed if the other one is accepted.

@ghostghost added the Review - NeededThe PR is being reviewed labelAug 5, 2022
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelJan 2, 2025
@iSazonoviSazonov changed the titleAdd helper in EnumSingleTypeConverter to get enum names-arrayAdd helper in EnumSingleTypeConverter to get enum names as arrayJan 2, 2025
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelJan 2, 2025
@iSazonoviSazonov merged commitc0d7fb7 intoPowerShell:masterJan 2, 2025
38 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedJan 2, 2025
edited by unfurl-linksbot
Loading

📣 Hey@fflaten, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

@fflatenfflaten deleted the cleanup-getenumnames branchJanuary 2, 2025 20:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iSazonoviSazonoviSazonov approved these changes

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@fflaten@iSazonov@adityapatwardhan

[8]ページ先頭

©2009-2025 Movatter.jp