Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix parameter completion when script requirements fail#17687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

MartinGC94
Copy link
Contributor

@MartinGC94MartinGC94 commentedJul 14, 2022
edited
Loading

PR Summary

Allows tab completion for parameters to continue working when script requirements like#requires -RunAsAdministrator fail due to the current session not meeting the script requirements.

PR Context

Fixes#4549

PR Checklist

@pull-request-quantifier-deprecated

This PR has36 quantified lines of changes. In general, a change size of upto200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra SmallSize       : +31 -5Percentile : 14.4%Total files changed: 5Change summary by file extension:.cs : +14 -5.ps1 : +17 -0

Change counts above are quantified counts, based on thePullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using thecontext generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out theExcluded section from yourprquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in yourprquantifier.yaml context profile.
    • Only use the labels that matter to you,see context specification to customize yourprquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added:+1 -0
  • One line was deleted:+0 -1
  • One line was modified:+1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghostghost assignedPaulHiginJul 14, 2022
@MartinGC94
Copy link
ContributorAuthor

Looking at the test failures, I guess we can't just ignore those errors in every scenario. I assumed I could because Experimental and hidden param attributes are ignored.
One solution could be to only ignore errors for type constraints but that won't help scenarios where scripts are using an attribute that hasn't been loaded yet.
Are there any other solutions?

@iSazonov
Copy link
Collaborator

WG discussion tag.

On the one hand it makes sense to have more freedom with#requires -RunAsAdministrator or hidden scenarios for example, but on the other hand I don't see the point of doing this for types that are not loaded.

@ghostghost added the Review - NeededThe PR is being reviewed labelJul 22, 2022
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@daxian-dbw
Copy link
Member

@MartinGC94 Sorry for taking so long to review. Can you please resolve the conflicts for this PR?

@ghostghost removed the Review - NeededThe PR is being reviewed labelApr 25, 2023
@ghostghost added the Review - NeededThe PR is being reviewed labelMay 3, 2023
@ghost
Copy link

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days.
Maintainer, please provide feedback and/or mark it asWaiting on Author

@iSazonov
Copy link
Collaborator

@MartinGC94 Please resolve merge conflicts and rebase.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot removed the Review - NeededThe PR is being reviewed labelFeb 26, 2025
@iSazonoviSazonov added the CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change Log labelFeb 26, 2025
@MartinGC94
Copy link
ContributorAuthor

I reverted the compiler changes as I don't think that's the right solution for that problem. So now this PR is only about the#requires completion fix.

@iSazonoviSazonov self-requested a reviewMarch 3, 2025 18:53
@iSazonov
Copy link
Collaborator

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@iSazonoviSazonov changed the titleFix parameter completion for invalid scriptsFix parameter completion when script requirements failMar 7, 2025
@iSazonoviSazonovenabled auto-merge (squash)March 7, 2025 04:11
@iSazonoviSazonov merged commitf7ae422 intoPowerShell:masterMar 7, 2025
39 of 41 checks passed
@microsoft-github-policy-serviceMicrosoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-servicebot commentedMar 7, 2025
edited by unfurl-linksbot
Loading

📣 Hey@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗https://aka.ms/PSRepoFeedback

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iSazonoviSazonoviSazonov approved these changes

@daxian-dbwdaxian-dbwAwaiting requested review from daxian-dbw

@SeeminglyScienceSeeminglyScienceAwaiting requested review from SeeminglyScience

Assignees

@iSazonoviSazonov

Labels
CL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogExtra SmallWG-Interactive-IntelliSensetab completion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter completion should work even when #requires fails
4 participants
@MartinGC94@iSazonov@daxian-dbw@PaulHigin

[8]ページ先頭

©2009-2025 Movatter.jp