- Notifications
You must be signed in to change notification settings - Fork7.7k
Fix parameter completion when script requirements fail#17687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix parameter completion when script requirements fail#17687
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR has Quantification details
Why proper sizing of changes mattersOptimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful?👍 :ok_hand: :thumbsdown: (Email) |
Looking at the test failures, I guess we can't just ignore those errors in every scenario. I assumed I could because Experimental and hidden param attributes are ignored. |
WG discussion tag. On the one hand it makes sense to have more freedom with |
ghost commentedJul 22, 2022
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days. |
Uh oh!
There was an error while loading.Please reload this page.
@MartinGC94 Sorry for taking so long to review. Can you please resolve the conflicts for this PR? |
ghost commentedMay 3, 2023
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for7 days. |
@MartinGC94 Please resolve merge conflicts and rebase. |
I reverted the compiler changes as I don't think that's the right solution for that problem. So now this PR is only about the |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Ilya <darpa@yandex.ru>
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
f7ae422
intoPowerShell:masterUh oh!
There was an error while loading.Please reload this page.
microsoft-github-policy-servicebot commentedMar 7, 2025 • edited by unfurl-linksbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by unfurl-linksbot
Uh oh!
There was an error while loading.Please reload this page.
📣 Hey@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗https://aka.ms/PSRepoFeedback |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Allows tab completion for parameters to continue working when script requirements like
#requires -RunAsAdministrator
fail due to the current session not meeting the script requirements.PR Context
Fixes#4549
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).