- Notifications
You must be signed in to change notification settings - Fork407
Drop v3 and v4 support from build#2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
SeeminglyScience left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
bergmeister left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version.
I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest
andyleejordan commentedMar 14, 2025
Yes indeed. I'll cut this down a bit to start. |
andyleejordan commentedMar 14, 2025
@bergmeister looking at it with a fresh set of eyes I'm thinking thisis a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests. |
e849068 intomainUh oh!
There was an error while loading.Please reload this page.
bergmeister commentedMar 14, 2025
Ok, I was more thinking from an end user perspective because if binaries are missing in new release, there is no hack to still be able to use it. But there is no right and wrong, just a question of speed of change and how many eggs to crack for the omelette in one go |
Uh oh!
There was an error while loading.Please reload this page.
This leaves all the guarded v3 and v4 implementation and test code, but starts the removal of support by dropping it from the build and updating the manifest.