Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drop v3 and v4 support from build#2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
andyleejordan merged 2 commits intomainfromps-5
Mar 14, 2025
Merged

Drop v3 and v4 support from build#2081

andyleejordan merged 2 commits intomainfromps-5
Mar 14, 2025

Conversation

@andyleejordan
Copy link
Member

@andyleejordanandyleejordan commentedMar 13, 2025
edited
Loading

This leaves all the guarded v3 and v4 implementation and test code, but starts the removal of support by dropping it from the build and updating the manifest.

Copy link
Collaborator

@SeeminglyScienceSeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Copy link
Collaborator

@bergmeisterbergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version.
I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest

@andyleejordan
Copy link
MemberAuthor

There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version. I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest

Yes indeed. I'll cut this down a bit to start.

bergmeister reacted with thumbs up emoji

@andyleejordanandyleejordan changed the titleWIP: Drop v3 and v4 support from build and codeDrop v3 and v4 support from buildMar 14, 2025
@andyleejordan
Copy link
MemberAuthor

@bergmeister looking at it with a fresh set of eyes I'm thinking thisis a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests.

@andyleejordanandyleejordan merged commite849068 intomainMar 14, 2025
6 checks passed
@andyleejordanandyleejordan deleted the ps-5 branchMarch 14, 2025 18:19
@bergmeister
Copy link
Collaborator

@bergmeister looking at it with a fresh set of eyes I'm thinking thisis a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests.

Ok, I was more thinking from an end user perspective because if binaries are missing in new release, there is no hack to still be able to use it. But there is no right and wrong, just a question of speed of change and how many eggs to crack for the omelette in one go

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bergmeisterbergmeisterbergmeister left review comments

@SeeminglyScienceSeeminglyScienceSeeminglyScience approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andyleejordan@bergmeister@SeeminglyScience

[8]ページ先頭

©2009-2025 Movatter.jp