Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add exception message for missing rules#1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Tadas
Copy link
Contributor

PR Summary

Fixes#1875

PR Checklist

CultureInfo.CurrentCulture,
Strings.RulesNotFound),
ErrorCategory.ResourceExists,
newException(errorMessage),
Copy link
Collaborator

@bergmeisterbergmeisterFeb 17, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

where this error is thrown, are we sure the only reason could be missing rules@Tadas ?
Kicked off CI for now to see what tests say

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bergmeister I know we didn't get an answer to this; thoughts on merging for v1.3?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

actually, on closer inspection of the diff, only 2 things are changing and they aren't of concern:

  • errorMessage is passed into Exception instead of nothing, which is an improvement
  • ErrorCategory is changed from ResourceExists to ResourceUnavailable, which I guess is a bit better butObjectNotFound is maybe even better so will change it to that. This is the same category thatgci notExists returns

@andyleejordanandyleejordanenabled auto-merge (squash)March 14, 2025 18:20
@andyleejordanandyleejordan merged commitae712f7 intoPowerShell:mainMar 14, 2025
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bergmeisterbergmeisterbergmeister approved these changes

@andyleejordanandyleejordanAwaiting requested review from andyleejordan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get-ScriptAnalyzerRule throws "Exception of type 'System.Exception' was thrown." when path does not contain rules

3 participants

@Tadas@andyleejordan@bergmeister
[8]ページ先頭
©2009-2025 Movatter.jp