- Notifications
You must be signed in to change notification settings - Fork407
Generate strongly typed resources as part of build#1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JamesWTruher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this looks good - it's great that we don't need to do this manually.
JamesWTruher commentedSep 11, 2023
@bergmeister if you could solve the merge conflict that would be great. |
… into resgen# Conflicts:#Rules/Strings.Designer.cs
bergmeister commentedSep 17, 2023
@JamesWTruher done. resolution was easy because this PR removes Strings.Designer.cs |
bergmeister commentedJan 2, 2024
Close and re-open to get latest CI check |
PR Summary
At the moment one needs to update the
Strings.Designer.csfiles when new entries are adding toString.resxfiles because the .NET CLI cannot generate them by default, which makes it hard for developers that do not use Visual Studio but VS-Code or just CLI. However, there is a way to make this work and generate the strongly resource as part of the build and make it work for CLI, VS-Code (when it does a restore) and Visual Studio, which uses MSBuild, see here:dotnet/msbuild#4751PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.