- Notifications
You must be signed in to change notification settings - Fork407
AvoidUsingPositionalParameter: Check if command has parameters to avoid having az in default CommandAllowList#1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JamesWTruher commentedJan 16, 2024
@bergmeister should we have any validation for this new behavior? Not about removing "az", but rather the command having no parameters |
JamesWTruher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just 1 question
Uh oh!
There was an error while loading.Please reload this page.
JamesWTruher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is fine
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This is an enhancement to
CommandAllowListintroduced in#1846To avoid having
azas the default in it, return now the discovered command and inspect whether it has parameters. If not, which is the case for the az CLI, then do not continue analyzing usage of that command.Also, az has backed out their change since then so with latest version of az, we don't need it as default allow-list anyway.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.