Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

AvoidUsingPositionalParameter: Check if command has parameters to avoid having az in default CommandAllowList#1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@bergmeister
Copy link
Collaborator

@bergmeisterbergmeister commentedOct 24, 2022
edited
Loading

PR Summary

This is an enhancement toCommandAllowList introduced in#1846
To avoid havingaz as the default in it, return now the discovered command and inspect whether it has parameters. If not, which is the case for the az CLI, then do not continue analyzing usage of that command.
Also, az has backed out their change since then so with latest version of az, we don't need it as default allow-list anyway.

PR Checklist

@bergmeisterbergmeister marked this pull request as ready for reviewOctober 25, 2022 16:43
@JamesWTruher
Copy link
Contributor

@bergmeister should we have any validation for this new behavior? Not about removing "az", but rather the command having no parameters

Copy link
Contributor

@JamesWTruherJamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just 1 question

@bergmeisterbergmeisterenabled auto-merge (squash)February 12, 2024 18:10
Copy link
Contributor

@JamesWTruherJamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is fine

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@JamesWTruherJamesWTruherJamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergmeister@JamesWTruher

[8]ページ先頭

©2009-2025 Movatter.jp