- Notifications
You must be signed in to change notification settings - Fork407
Fix NRE when custom rules omit optional properties in diagnostics#1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bergmeister left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, only suggestion is to replace hard-coded property names with code references using things like e.g.nameof. Also, should we try to make the property query case insensitive for the property name itself as I think at the moment it'd be case sensitive
PR Summary
Fixes#1714.
These changes allow custom rules to emit diagnostics (or PSObjects that turn into diagnostics) with optional properties unset.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.