Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make UseSingularNouns rule work on PowerShell Core#1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rjmholt merged 46 commits intoPowerShell:masterfrombergmeister:UseSingularNoun_PSCore
Apr 28, 2021

Conversation

@bergmeister
Copy link
Collaborator

@bergmeisterbergmeister commentedJan 23, 2021•
edited
Loading

PR Summary

Fixes#1626

This uses the open sourcePluralize.NET NuGet package, which uses the MIT licence. The added payload is only 20KB once.
Also enhance existing code to not constructPluralizationservice in foreach loop.

PR Checklist

@bergmeisterbergmeister changed the titleMake UseSingularNouns rule work for PowerShell Core versionsMake UseSingularNouns rule work on PowerShell CoreJan 23, 2021
@bergmeisterbergmeister marked this pull request as ready for reviewJanuary 23, 2021 10:43
@SydneyhSmith
Copy link
Collaborator

Ah unfortunately, the fact that the package is unlicensed does block us from accepting it

@bergmeister
Copy link
CollaboratorAuthor

bergmeister commentedFeb 3, 2021•
edited
Loading

Ok, will contact the author if an MIT license or something similar can be added as it was probably not intentional by the author. Would the licence need to be on the NuGet package or just the source repo?
Alternatively, there is a similar NuGet package with MIT license but that is not preferred as the implementation is different to the one that I suggested, which is just a .Net Core port.
https://github.com/sarathkcm/Pluralize.NET

@bergmeister
Copy link
CollaboratorAuthor

@SydneyhSmith I updated it to use thePluralize.NET library instead, which has an MIT licence.

@SydneyhSmith
Copy link
Collaborator

Thanks@bergmeister that package looks good to us

bergmeister reacted with thumbs up emojibergmeister and rjmholt reacted with hooray emoji

@rjmholtrjmholt self-assigned thisApr 22, 2021
@rjmholtrjmholtforce-pushed theUseSingularNoun_PSCore branch from47150bf to9327e6fCompareApril 23, 2021 00:18
@rjmholtrjmholtforce-pushed theUseSingularNoun_PSCore branch from1402a5e to5832be4CompareApril 27, 2021 19:22
@rjmholtrjmholt merged commit1eb5671 intoPowerShell:masterApr 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@JamesWTruherJamesWTruherJamesWTruher left review comments

@rjmholtrjmholtrjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholtrjmholt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PSUseSingularNouns Rule doesn't work in PowerShell Core but does in PowerShell

4 participants

@bergmeister@SydneyhSmith@rjmholt@JamesWTruher
[8]ページ先頭
©2009-2025 Movatter.jp