Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix bug with PipelineIndentationStyle.None where break instead of continue statement was used#1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bergmeister merged 7 commits intoPowerShell:masterfrombergmeister:issue1496
Jun 11, 2020

Conversation

@bergmeister
Copy link
Collaborator

@bergmeisterbergmeister commentedMay 13, 2020•
edited
Loading

PR Summary

Fixes#1496

Also added another test case that would've caught it.

PR Checklist

…tinue statement was used. TODO: Fix test that starts to fail because of this now
bergmeisterand others added2 commitsJune 11, 2020 21:47
@bergmeisterbergmeister merged commit8e6182f intoPowerShell:masterJun 11, 2020
intsearchLine;
do
{
searchLine=tokens[searchIndex].Extent.StartLineNumber;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh! Myswitch suggestion got lost! Ugh, too much context switching... Anyway, not an issue

Copy link
CollaboratorAuthor

@bergmeisterbergmeisterJun 11, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thought I addressed your comment here by not initializing it:#1497 (comment)
Or did you mean a switch aroundtokens[searchIndex].Kind? I don't see too much value in it tbh. Switch statements don't look that much cleaner for simple cases like that IMHO because of their ceremony that requires additional indentation layer, break statements, etc..
Otherwise we can always create a follow up PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JamesWTruherJamesWTruherAwaiting requested review from JamesWTruher

1 more reviewer

@rjmholtrjmholtrjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bergmeisterbergmeister

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PipelineIndentationStyle: Incorrect formatting when using None

2 participants

@bergmeister@rjmholt
[8]ページ先頭
©2009-2025 Movatter.jp