Fixes#1369
Unfortunately this issue could only be reproduced when PSSA is hosted within PSES where the root of the workspace becomes the working directory of the runspace pool, which causesGet-Command ..\PathToScript.ps1 to return a command type of ExternalScript, which then makes it into the command cache and causes the false positve.
The fix is to search only for cmdlets/functions where the implicitGet- aliasing applies.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all.cs,.ps1 and.psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is notWork in Progress.
- If the PR is work in progress, please add the prefixWIP: to the beginning of the title and remove the prefix when the PR is ready.

Fix false positive of AvoidAlias rule for implicit aliasing of Get- c…

3c16eae

…ommands for the CommandType ExternalScript

bergmeister added the Issue - Bug label

Jan 2, 2020

bergmeister requested review fromJamesWTruher andrjmholt

January 2, 2020 22:02

retrigger ci

fdd7bbe

JamesWTruher approved these changes

Jan 28, 2020

View reviewed changes

Copy link

Contributor

JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks great - do we need any additional validation, or is what we have sufficient?

Copy link

CollaboratorAuthor

bergmeister commentedJan 28, 2020

The manual end to end test (in vs code) is all I could as somehow this happens only when PSSA is hosted in the vs code extension where those command info cache entries got populated.