Update AzF profile to be useful#1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

rjmholt merged 3 commits intoPowerShell:masterfromrjmholt:azf-az-profile

Sep 14, 2019

Merged

Update AzF profile to be useful#1341

rjmholt merged 3 commits intoPowerShell:masterfromrjmholt:azf-az-profile

Sep 14, 2019

Conversation

Copy link

Contributor

rjmholt commentedSep 13, 2019

PR Summary

I've run the profile collector on the AzF profile (with some difficulty) and collected a new profile that captures the default Az installation.

I've also removed cmdlets that don't work in AzF despite being present, likeStart-Job andEnter-PSSession.

I had to make some small changes to the profile collector to not crash (plus one where I realised that collecting a function if we're not able to load it is unhelpful).

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all.cs,.ps1 and.psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is notWork in Progress.
- If the PR is work in progress, please add the prefixWIP: to the beginning of the title and remove the prefix when the PR is ready.

rjmholt added2 commits

September 13, 2019 15:23

Fix collection issue

225f004

Update AzF profile to be useful

098e4c0

bergmeister reviewed

Sep 13, 2019

View reviewed changes

Copy link

Collaborator

bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks ok to me but it broke 1 CI test:

    Context Targeting new-form Az profiles alongside older profiles      [-] Finds AzF problems with a script 7.37s        KeyNotFoundException: The given key 'InDisconnectedSession' was not present in the dictionary.        at <ScriptBlock>, C:\projects\psscriptanalyzer\Tests\Rules\UseCompatibleCommands.Tests.ps1: line 334

Copy link

ContributorAuthor

rjmholt commentedSep 13, 2019

Impressive that testing picked that up! I'll have to make some further edits

Fix alias

0c5e342

Copy link

ContributorAuthor

rjmholt commentedSep 14, 2019

Impressive that testing picked that up!

Have to credit you entirely for that@bergmeister -- you asked for those tests.

Looks like they're working now. Hopefully theLazys don't hide other faults. I took out parameters and commands manually, and it looks like I took a parameter out without its alias there.