Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PipelineIndentationStyle: Fix edge case where pipeline was incorrectly detected to span mutliple lines due to backticks in the command leading up to the pipeline#1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@bergmeister
Copy link
Collaborator

PR Summary

Fixes#1311 by refining the logic to determine if a pipeline spans one line or not. Previously it compared only theStartLineNumber of the first and last pipeline to be equal. Now the logic needs to be tweaked with anOR condition where also theEndLineNumber of the first and last pipeline is checked for equality.
Code was also made more readable.

PR Checklist

Co-Authored-By: Robert Holt <rjmholt@gmail.com>
@bergmeisterbergmeister merged commit171c81d intoPowerShell:masterAug 19, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JamesWTruherJamesWTruherAwaiting requested review from JamesWTruher

1 more reviewer

@rjmholtrjmholtrjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PipelineIndentationStyle: When set to other settings other than NoIndentation: Edge case: Incorrect indentation due to backtick

2 participants

@bergmeister@rjmholt

[8]ページ先頭

©2009-2025 Movatter.jp