Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix edge case when PipelineIndentationStyle is not set to NoIndentation#1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@bergmeister
Copy link
Collaborator

@bergmeisterbergmeister commentedJun 15, 2019
edited by rjmholt
Loading

PR Summary

Fixes#1236
Note that the originally reported issue was fixed in 1.18.1 but the issue creator posted another edge case after the releasehere, which is the issue that the author addresses.

When PipelineIndentationStyle is set to IncreaseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipeline:
The determination if the pipelineAst is on one line needs to be tweaked to include the case where pipelines are on the same line but a multi-line expressions follows. This lead to the next brace having one level of indentation too little.

Context: 1.18.1 fixed most PipelineIndentationStyle bugs when it is not set to NoIndentation (which is the default in VS Code at the moment), but this edge case was missed out.

Linux failure is due to the recent AppVeyor image update and affects development branch as well

PR Checklist

andreacapriplexure and PhilipHaglund reacted with thumbs up emoji
…aseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipelineThe determination if the pipelineAst is on one line needs to be tweaked to include the case where pipelines are on the same line but a multi-line expressions follows
@bergmeisterbergmeister marked this pull request as ready for reviewJune 18, 2019 12:44
@bergmeisterbergmeister changed the base branch fromdevelopment tomasterJune 18, 2019 21:07
Copy link
Contributor

@rjmholtrjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fix looks good to me

@felixfbecker
Copy link

Anything blocking this?

@bergmeister
Copy link
CollaboratorAuthor

No, I just addressed the variable name suggestion. Sometimes I also wait a bit for@JamesWTruher to double check it as well. Otherwise we are good to go I think

@felixfbecker
Copy link

Is 21 days enough time? :)

PhilipHaglund reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@rjmholtrjmholtrjmholt approved these changes

@JamesWTruherJamesWTruherJamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Closing brace of if block is deindented if block contains a pipe

4 participants

@bergmeister@felixfbecker@rjmholt@JamesWTruher

[8]ページ先頭

©2009-2025 Movatter.jp