- Notifications
You must be signed in to change notification settings - Fork407
Fix edge case when PipelineIndentationStyle is not set to NoIndentation#1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…aseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipelineThe determination if the pipelineAst is on one line needs to be tweaked to include the case where pipelines are on the same line but a multi-line expressions follows
rjmholt left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fix looks good to me
Uh oh!
There was an error while loading.Please reload this page.
felixfbecker commentedJul 6, 2019
Anything blocking this? |
bergmeister commentedJul 6, 2019
No, I just addressed the variable name suggestion. Sometimes I also wait a bit for@JamesWTruher to double check it as well. Otherwise we are good to go I think |
felixfbecker commentedJul 6, 2019
Is 21 days enough time? :) |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Fixes#1236
Note that the originally reported issue was fixed in 1.18.1 but the issue creator posted another edge case after the releasehere, which is the issue that the author addresses.
When PipelineIndentationStyle is set to IncreaseIndentationForFirstPipeline or IncreaseIndentationAfterEveryPipeline:
The determination if the pipelineAst is on one line needs to be tweaked to include the case where pipelines are on the same line but a multi-line expressions follows. This lead to the next brace having one level of indentation too little.
Context: 1.18.1 fixed most PipelineIndentationStyle bugs when it is not set to NoIndentation (which is the default in VS Code at the moment), but this edge case was missed out.
Linux failure is due to the recent AppVeyor image update and affects development branch as well
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.