- Notifications
You must be signed in to change notification settings - Fork407
Prevent PSCloseBrace crash if hashtable definition start on first token and there is a PSCloseBrace violation#1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…is a PSCloseBrace violation
rjmholt left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
JamesWTruher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure the call toInvoke-Formatter belongs in line 107
| } | ||
| It"Should not crash when hashtable is defined on first token" { | ||
| $def=@' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this can also be written as follows:
$def = "@{ `n Key = 1 }"and it will cause the same error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and it's a very specific set of characters. This"@{key=1}" doesn't cause the problem but"@{``nkey=1}" does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, I can change it to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done now
| $violations=Invoke-ScriptAnalyzer-ScriptDefinition$def-Settings$settings-ErrorAction Stop | ||
| $violations.Count| Should-Be1 | ||
| Invoke-Formatter-ScriptDefinition$def-ErrorAction Stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There doesn't seem to be an assertion here. Since the formatter uses the same rule, this seems superfluous. (do you want an explicit test for the formatter?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The assertion here is that the formatter does not throw an exception. The call toInvoke-ScriptAnalyzer is the core unit test but the call toInvoke-Formatter is the integration test.
PR Summary
Fixes#1219
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.