- Notifications
You must be signed in to change notification settings - Fork407
Fix UseCompatibleSyntax class error message#1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix UseCompatibleSyntax class error message#1215
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bergmeister left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good spot. Looks good to me.
Optional suggestion would be to create a wrapper function for creating the error message since there are now 6 usages ofStrings.UseCompatibleSyntaxError, this would improve readability when using named parameters to call it and would also add a small safety net since one only sees a mismatch of number of parameter at runtime.
JamesWTruher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks fine
PR Summary
A bug in the UseCompatibleSyntax rule means error messages come out looking very bad. This fixes that.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.