Fixes#1187 by excluding single-line pipelines to avoid reduce indentation level incorrectly. This case showed up only when there is already some indentation.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all.cs,.ps1 and.psm1 files have the correct copyright header
Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
This PR is ready to merge and is notWork in Progress.
- If the PR is work in progress, please add the prefixWIP: to the beginning of the title and remove the prefix when the PR is ready.

Fix issue whereby single-line pipeline reduces indentation level inco…

c921ea4

…rrectly (problem only showed up when there was already existing indentation due to ClipNegative

bergmeister added Issue - Bug Area - Formatter labels

Mar 24, 2019

bergmeister requested review fromJamesWTruher,TylerLeonhardt andrjmholt

March 24, 2019 19:22

rjmholt reviewed

Mar 25, 2019

View reviewed changes

Rules/UseConsistentIndentation.cs OutdatedShow resolvedHide resolved

Rules/UseConsistentIndentation.csShow resolvedHide resolved

Apply suggestions from code review

c72345c

Co-Authored-By: bergmeister <c.bergmeister@gmail.com>

Copy link

CollaboratorAuthor

bergmeister commentedMar 25, 2019

I applied the suggestions, I have to look at the test failures though, locally it was fine.

rjmholt approved these changes

Mar 25, 2019

View reviewed changes

JamesWTruher approved these changes

Mar 26, 2019

View reviewed changes

JamesWTruher reviewed

Mar 26, 2019

View reviewed changes

Copy link

Contributor

JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it looks like this isn't quite right based on test failures

JamesWTruher requested review fromJamesWTruher andrjmholt

March 26, 2019 21:27

bergmeister added2 commits

March 27, 2019 21:22

Merge branch 'development' ofhttps://github.com/PowerShell/PSScriptA…

5ea0fba

…nalyzer into FixUseConsistentIndentationBugWithSingleLinePipeline

Fix tests by replacing break with continue (forgot I was inside for l…

78e91f2

…oop and not switch statement), simple mistake

Copy link

CollaboratorAuthor

bergmeister commentedMar 27, 2019

@rjmholt @JamesWTruher @TylerLeonhardt I fixed the build, it was a simple mistake, I used abreak statement when I actually meant to use acontinue statement.